Uploaded image for project: 'NetarchiveSuite'
  1. NetarchiveSuite
  2. NAS-2743

Warning: 0 errors were found

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Minor
    • None
    • 5.4
    • None
    • None

    Description

      During the following release test:

      TEST 6 (https://sbforge.org/display/NAS/TEST6+Robustness+test) - the step called "Verify the restarted system. On devel@kb-test-adm-001"

      the following warning appears:

      Domain.setCrawlerTraps - 0 errors were found:
      e.g.GUIApplication.2018-04-09.0.log:15:35:16.260 WARN d.n.harvester.datamodel.Domain.setCrawlerTraps - 0 errors were found:

      The code in Domain.setCrawlerTraps prints a warning, even though there are no errors encountered.

      This:

      if (strictMode)
      if (errMsgs.size() > 0)

      { throw new ArgumentNotValid(errMsgs.size() + " errors were found: " + StringUtils.conjoin(",", errMsgs)); }

      else

      { log.warn(errMsgs.size() + " errors were found: " + StringUtils.conjoin(",", errMsgs)); }

      should be changed into:

      if (errMsgs.size() > 0) {
      if (strictMode)

      { throw new ArgumentNotValid(errMsgs.size() + " errors were found: " + StringUtils.conjoin(",", errMsgs)); }

      else

      { log.warn(errMsgs.size() + " errors were found: " + StringUtils.conjoin(",", errMsgs)); }

      }

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jrg Jeppe Ravn-Grove (Inactive)
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: