Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4
Affects Version/s: 4.2
Component/s: None
Labels:
None

Verification:
Hide

The fix is verified by the Unit Test. If it is thought necessary, one could test it as part of the release test:

Start a harvest

Create some spurious files in the harvest directory while the harvest is happening

Check that they are processed separately from the harvest files. (I haven't checked what the precise expected behaviour is.)
Show
The fix is verified by the Unit Test. If it is thought necessary, one could test it as part of the release test: Start a harvest Create some spurious files in the harvest directory while the harvest is happening Check that they are processed separately from the harvest files. (I haven't checked what the precise expected behaviour is.)

Description

The code block

 if (!lostfilesDir.exists()) {
                        FileUtils.createDir(lostfilesDir);
                        File moveTo = new File(lostfilesDir,
                                               archiveFile.getName());
                        archiveFile.renameTo(moveTo);
                        movedFiles.add(moveTo);
                    }

is wrong. The if block should only include the createDir() call.

The corresponding unit test either passes or fails depending on the order in which the two bad-files are processed, so the result is system-dependent. The fix is trivial but I'll beef up the unit test to make sure it always fails with the existing code.

Attachments

Activity

People

Assignee:: Colin Rosenthal

Reporter:: Colin Rosenthal

Inspector:: Søren Vejrup Carlsen (Inactive)

Watchers:: 1 Start watching this issue

Dates

Created:: 31/Mar/14 3:10 PM

Updated:: 01/May/14 1:12 PM

Resolved:: 01/May/14 1:12 PM

Time Tracking

Estimated:

Remaining:

Logged:

Not Specified