Uploaded image for project: 'NetarchiveSuite'
  1. NetarchiveSuite
  2. NAS-2249

FixedDomainConfigurationCountJobGenerator is not thread-safe

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: 4.4
    • Component/s: Harvest Definition
    • Labels:
      None
    • Organization:
      BNF

      Description

      After fixing NAS-2069, revision 2618 (part of NAS-2169 fix) removed synchronized statement from generateJobs in FixedDomainConfigurationCountJobGenerator. But the job generation methods make use of an instance boolean member, so the class is not thread safe anymore.

      In production we had a broad harvest job generation that got intertwined with a focused job generation, resulting in all subsequent broad jobs having the focused configuration count instead of the broad one.

        Attachments

          Activity

            People

            • Assignee:
              ngiraud Nicolas Giraud (Inactive)
              Reporter:
              ngiraud Nicolas Giraud (Inactive)
              Inspector:
              Søren Vejrup Carlsen
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 0.2h
                0.2h