Uploaded image for project: 'NetarchiveSuite'
  1. NetarchiveSuite
  2. NAS-2158

Restart or Reject failed job has flawed javascript

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Trivial
    • None
    • 3.18.0, 3.18.3, 3.20.0, 4.0
    • GUI
    • None

    Description

      In Harveststatus-alljobs.jsp

      The script tag before the html tag should be moved inside the head section or alternatively inside the body. If it is static it could easily just be stored as a separate .js file and reference from the .jsp. Similarly for most of the script tags in the body, those only defining function should also be moved to the head section.

      The javascript code which is run when pressing either restart or reject
      could also be improved.

      function collapse_row(jobid)

      { var row = document.getElementById('row_'+jobid); row.style.visibility='collapse'; }

      The javascript should ideally changed the status/harvest errors columns instead of almost removing the row.

      Removing it completely would be:
      cObj.style.visibility = 'hidden';
      cObj.style.display = 'none';

      But the user friendly way would be to not remove the row but to change the columns removing the buttons and insert a new status instead.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              nicl@kb.dk Nicholas Clarke (Inactive)
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: