Uploaded image for project: 'Bitrepository'
  1. Bitrepository
  2. BITMAG-1133

Reference client understands salt input as a Hex String. This is NOT clear from the docs

    XMLWordPrintable

Details

    • Bit Sprint 1
    • Hide

      Running e.g. PutFileCmd with no arguments now correctly tells that the -S option expects a hexadecimal string, and providing anything else will also now throw an error. 

      Show
      Running e.g. PutFileCmd with no arguments now correctly tells that the -S option expects a hexadecimal string, and providing anything else will also now throw an error. 

    Description

      [abr@pc596 bitrepository-client-1.9-RC1]$ ./bin/bitmag.sh put-file -h
      Takes the following arguments:
      -s The path to the directory with the settings files for the client
      -k The path to the file containing the private key.
      -v Makes the client more verbose
      -c The id for the collection to perform the operation on.
      -i The id for the file to perform the operation on.
      -p [OPTIONAL] The id of the pillar where the operation should be performed. If undefined the operation is performed on all pillars.
      -f The path to the file, which needs to be  uploaded. Is required, unless a URL is given.
      -u The URL for the file to be put. Is required, unless the actual file is given.
      -C The checksum for the file to be retrieved. Required if using an URL.
      -R [OPTIONAL] The algorithm of checksum to request in the response from the pillars.
      -S [OPTIONAL] The salt of checksum to request in the response. Requires the ChecksumType argument.
      -d If this argument is present, then the file will be removed from the server, when the operation is complete.
      Missing argument: Unrecognized option: -h
      

      From this I cannot see that the value for the -S flag should be a string of hex chars, such as "abcd" or "1000".
      The tests in https://sbforge.org/display/BITMAG/PutFile+tests
      actually use the value "salt" as the salt, which is not a hex string

      Attachments

        Activity

          People

            rbkr Rasmus Bohl Kristensen
            abr Asger Askov Blekinge (Inactive)
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: