Bitrepository

Severity

Blocker 0
Critical 42
Major 573
Minor 472
Info 27

Rule

Bad practice - Method may fail to close stream 5
Security - Array is stored directly 4
Avoid Catching Throwable 3
Empty If Stmt 3
Performance - Inefficient use of keySet iterator instead of entrySet iterator 3
Dodgy - Load of known null value 3
Correctness - Possible null pointer dereference 3
Correctness - Nullcheck of value previously dereferenced 2
Dodgy - Dead store to local variable 2
Multithreaded correctness - Call to static DateFormat 2
Multithreaded correctness - Wait not in loop 2
Bad practice - Equals method should not assume anything about the type of its argument 1
Dodgy - Unchecked/unconfirmed cast 1
Correctness - Invocation of toString on an array 1
Performance - Method invokes inefficient Number constructor; use static valueOf instead 1
Multithreaded correctness - Inconsistent synchronization 1
Multithreaded correctness - Incorrect lazy initialization of static field 1
Bad practice - equals() method does not check for null argument 1
Correctness - Method attempts to access a result set field with index 0 1
Security - A prepared statement is generated from a nonconstant String 1
Multithreaded correctness - Static DateFormat 1
Inefficient String Buffering 100
Visibility Modifier 73
Avoid Duplicate Literals 38
If Stmts Must Use Braces 34
Avoid Throwing Raw Exception Types 33
Malicious code vulnerability - May expose internal representation by incorporating reference to mutable object 26
Malicious code vulnerability - May expose internal representation by returning reference to mutable object 24
Hide Utility Class Constructor 21
Parameter Assignment 19
If Else Stmts Must Use Braces 19
Cyclomatic Complexity 18
Performance - Unread field: should this field be static? 18
Final Class 17
System Println 12
Local Variable Name 10
Signature Declare Throws Exception 10
Avoid Print Stack Trace 10
Simplify Boolean Return 8
Preserve Stack Trace 8
Bad practice - Method invokes System.exit(...) 7
Performance - Unread field 6
Unused Private Field 6
Hidden Field 5
Bad practice - Method ignores exceptional return value 5
Close Resource 5
Unnecessary Local Before Return 5
Performance - Should be a static inner class 4
Constructor Calls Overridable Method 4
Boolean Expression Complexity 4
Inner Assignment 3
Anon Inner Length 3
Member name 2
Method Name 2
Use Index Of Char 2
Unused formal parameter 2
Dodgy - Exception is caught when Exception is not thrown 2
Avoid Rethrowing Exception 2
Bad practice - Method ignores results of InputStream.read() 1
Multithreaded correctness - Unconditional wait 1
Avoid Catching NPE 1
Naming - Suspicious constant field name 1
Ncss Method Count 1
Parameter Name 1
Line Length 175
Magic Number 91
Modifier Order 76
Constant Name 47
Redundant Throws 23
Redundant Modifier 18
File Tab Character 15
Collapsible If Statements 12
Singular Field 7
Final Field Could Be Static 5
Empty Statement 2
Dont Import Sun 1
Unused Modifier 18
Unused Imports 9
Zoom   src/main/java/org/bitrepository/audittrails/store 87
Zoom   src/main/java/org/bitrepository/integrityservice/cache/database 82
Zoom   src/main/java/org/bitrepository/common/utils 73
Zoom   src/main/java/org/bitrepository/protocol/messagebus/logger 71
Zoom   src/main/java/org/bitrepository/protocol/security 47
Zoom   src/main/java/org/bitrepository/service/audit 45
Zoom   src/main/java/org/bitrepository/service/database 41
Zoom   src/main/java/org/bitrepository/integrityservice/workflow/step 38
Zoom   src/main/java/org/bitrepository/alarm/store 36
Zoom   src/main/java/org/bitrepository/integrityservice/cache 30
Zoom   src/main/java/org/bitrepository/pillar/store/checksumdatabase 28
Zoom   src/main/java/org/bitrepository/commandline 27
Zoom   src/main/java/org/bitrepository/integrityservice/web 25
Zoom   src/main/java/org/bitrepository/webservice 23
Zoom   src/main/java/org/bitrepository/service/workflow 21
Zoom   src/main/java/org/bitrepository/access 20
Zoom   src/main/java/org/bitrepository/common/settings 17
Zoom   src/main/java/org/bitrepository/integrityservice/reports 17
Zoom   src/main/java/org/bitrepository/protocol 17
Zoom   src/main/java/org/bitrepository/pillar/messagehandler 16
Zoom   src/main/java/org/bitrepository/pillar/store 15
Zoom   src/main/java/org/bitrepository/client/conversation 13
Zoom   src/main/java/org/bitrepository/integrityservice/workflow 13
Zoom   src/main/java/org/bitrepository/integrityservice/tools 13
Zoom   src/main/java/org/bitrepository 12
Zoom   src/main/java/org/bitrepository/service/contributor/handler 12
Zoom   src/main/java/org/bitrepository/audittrails/webservice 11
Zoom   src/main/java/org/bitrepository/protocol/messagebus 11
Zoom   src/main/java/org/bitrepository/audittrails/preserver 10
Zoom   src/main/java/org/bitrepository/pillar 9
Zoom   src/main/java/org/bitrepository/audittrails/collector 9
Zoom   src/main/java/org/bitrepository/access/getaudittrails 9
Zoom   src/main/java/org/bitrepository/alarm 9
Zoom   src/main/java/org/bitrepository/protocol/utils 9
Zoom   src/main/java/org/bitrepository/monitoringservice 8
Zoom   src/main/java/org/bitrepository/commandline/outputformatter 8
Zoom   src/main/java/org/bitrepository/access/getaudittrails/client 8
Zoom   src/main/java/org/bitrepository/protocol/http 7
Zoom   src/main/java/org/bitrepository/client/conversation/mediator 7
Zoom   src/main/java/org/bitrepository/utils 7
Zoom   src/main/java/org/bitrepository/commandline/output 7
Zoom   src/main/java/org/bitrepository/protocol/activemq 6
Zoom   src/main/java/org/bitrepository/commandline/clients 6
Zoom   src/main/java/org/bitrepository/access/getfileids/conversation 6
Zoom   src/main/java/org/bitrepository/access/getfileids 6
Zoom   src/main/java/org/bitrepository/access/getfile 6
Zoom   src/main/java/org/bitrepository/access/getchecksums/conversation 6
Zoom   src/main/java/org/bitrepository/pillar/common 6
Zoom   src/main/java/org/bitrepository/modify/replacefile 6
Zoom   src/main/java/org/bitrepository/commandline/utils 6
Zoom   src/main/java/org/bitrepository/access/getchecksums 5
Zoom   src/main/java/org/bitrepository/protocol/messagebus/destination 5
Zoom   src/main/java/org/bitrepository/modify/deletefile/conversation 5
Zoom   src/main/java/org/bitrepository/client/eventhandler 5
Zoom   src/main/java/org/bitrepository/modify/putfile 4
Zoom   src/main/java/org/bitrepository/modify/putfile/conversation 4
Zoom   src/main/java/org/bitrepository/commandline/eventhandler 4
Zoom   src/main/java/org/bitrepository/client/conversation/selector 4
Zoom   src/main/java/org/bitrepository/modify/replacefile/conversation 4
Zoom   src/main/java/org/bitrepository/common 4
Zoom   src/main/java/org/bitrepository/client 4
Zoom   src/main/java/org/bitrepository/service/contributor 4
Zoom   src/main/java/org/bitrepository/monitoringservice/alarm 3
Zoom   src/main/java/org/bitrepository/integrityservice 3
Zoom   src/main/java/org/bitrepository/alarm/alarmservice 3
Zoom   src/main/java/org/bitrepository/client/componentid 3
Zoom   src/main/java/org/bitrepository/modify/deletefile 3
Zoom   src/main/java/org/bitrepository/modify 2
Zoom   src/main/java/org/bitrepository/audittrails 2
Zoom   src/main/java/org/bitrepository/monitoringservice/webservice 2
Zoom   src/main/java/org/bitrepository/monitoringservice/status 2
Zoom   src/main/java/org/bitrepository/service/scheduler 2
Zoom   src/main/java/org/apache/http/impl/conn 2
Zoom   src/main/java/org/bitrepository/integrityservice/statistics 2
Zoom   src/main/java/org/bitrepository/integrityservice/collector 2
Zoom   src/main/java/org/bitrepository/access/getstatus/conversation 2
Zoom   src/main/java/org/bitrepository/service 1
Zoom   src/main/java/org/bitrepository/access/getfile/selectors 1
Zoom   src/main/java/org/bitrepository/access/getfile/conversation 1
Zoom   src/main/java/org/bitrepository/integrityservice/audittrail 1
Zoom   src/main/java/org/bitrepository/pillar/store/filearchive 1
Zoom   src/main/java/org/bitrepository/service/exception 1
Zoom   src/main/java/org/bitrepository/monitoringservice/collector 1
  AuditDatabaseConstants.java 31
  AuditTrailAdder.java 24
  FileSizeUtils.java 24
  AuditTrailContributerDAO.java 22
  ChecksumUpdater.java 21
  FileUpdater.java 19
  AuditDatabaseConstants.java 18
  ContributorQuery.java 16
  AlarmDatabaseExtractor.java 16
  WebserviceInputChecker.java 16
  RestIntegrityService.java 16
  StatisticsCreator.java 15
  ChecksumExtractor.java 14
  SqlScriptRunner.java 13
  TimeUtils.java 13
  GetChecksumsMessageLogger.java 13
  ReplaceFileMessageLogger.java 12
  AuditTrailStore.java 12
  ChecksumUtils.java 11
  IntegrityDAO.java 11
  GetFileIDsMessageLogger.java 11
  CommandLineClient.java 11
  GetAuditTrailsMessageLogger.java 11
  SecurityModuleConstants.java 10
  CollectionStat.java 9
  CertificateID.java 9
  JSONStreamingTools.java 9
  PutFileMessageLogger.java 9
  BasicClientFactory.java 9
  DatabaseMaintainer.java 9
  IntegrityDatabaseMigrator.java 8
  AuditTrailServiceDatabaseMigrator.java 8
  BasicIntegrityReporter.java 8
  JobID.java 7
  Settings.java 7
  Workflow.java 7
  CollectionsAdmin.java 7
  DefaultOutputHandler.java 7
  ConversationEventMonitor.java 7
  AlarmServiceFactory.java 7
  DatabaseUtils.java 7
  UpdateFileIDsStep.java 7
  AlarmDatabaseExtractionModel.java 7
  BasicSecurityManager.java 7
  RestAuditTrailService.java 6
  MonitoringServiceFactory.java 6
  StorageModel.java 6
  FileStorageModel.java 6
  PermissionStore.java 6
  PillarCollectionStat.java 6
  UpdateChecksumsStep.java 6
  RequestHandler.java 6
  DeleteFileMessageLogger.java 6
  HexUtils.java 6
  XMLFileSettingsLoader.java 6
  Base16Utils.java 6
  HandleMissingChecksumsStep.java 6
  ProtocolVersionLoader.java 6
  ActiveMQMessageBus.java 6
  HttpFileExchange.java 6
  CollectionsAdminLauncher.java 6
  IntegrityDBTools.java 5
  IntegrityCheckWorkflow.java 5
  AuditEventIterator.java 5
  MessageUtils.java 5
  CollectorInfo.java 5
  AuditPacker.java 5
  BlockingGetFileClient.java 5
  DatabaseManager.java 5
  AuditDatabaseExtractor.java 4
  LocalAuditTrailPreserver.java 4
  PillarRunner.java 4
  DBConnector.java 4
  CollectionSchedule.java 4
  AuditTrailConversationContext.java 4
  MessageBusManager.java 4
  MessageCategoryUtils.java 4
  OperationAuthorizor.java 4
  MessageSigner.java 4
  PagingGetChecksumsClient.java 4
  HandleDeletedFilesStep.java 4
  HandleChecksumValidationStep.java 4
  FileIDValidator.java 4
  FileIDsUtils.java 4
  AbstractOperationEvent.java 4
  TimeMeasurementUtils.java 4
  CollectionBasedConversationMediator.java 4
  GetFileMessageLogger.java 4
  WorkflowStatistic.java 4
  MessageVersionValidator.java 4
  AlarmDAOFactory.java 4
  AbstractClient.java 4
  IntegrityDAOFactory.java 4
  FileInfo.java 4
  WorkflowStatistic.java 4
  GetChecksumDistributionFormatter.java 4
  CommandLineArgumentsHandler.java 4
  DeleteFileCmd.java 3
  MessageLoggerProvider.java 3
  ChecksumDBMigrator.java 3
  AccessComponentFactory.java 3
  AuditTrailQuery.java 3
  AlarmDatabaseConstants.java 3
  ChecksumEntry.java 3
  PillarLauncher.java 3
  ConversationMediatorManager.java 3
  BlockingDeleteFileClient.java 3
  IntegrityServiceManager.java 3
  MessageAuthenticator.java 3
  IntegrityDAOUtils.java 3
  SimpleMessageBus.java 3
  BasicClient.java 3
  IntegrityReportWriter.java 3
  IntegrityContributors.java 3
  MessageHandlerContext.java 3
  GetChecksumsConversationContext.java 3
  ServiceUrl.java 3
  ChecksumsCompletePillarEvent.java 3
  IntegrityIssueIterator.java 3
  AuditTrailContributorDatabaseMigrator.java 3
  GetChecksumsRequestHandler.java 3
  JaxbHelper.java 3
  BlockingReplaceFileClient.java 3
  GetFileIDsConversationContext.java 3
  BasicMonitoringServiceAlerter.java 3
  ReceivedMessageHandler.java 3
  CalendarUtils.java 3
  ChecksumStorageModel.java 3
  AuditTrailResult.java 3
  FileIDsCompletePillarEvent.java 3
  ReplaceFileCmd.java 3
  PutFileCmd.java 3
  GetFileIDsClient.java 3
  ResponsePopulator.java 3
  ChecksumDAO.java 3
  FileUtils.java 2
  AlarmDatabaseMigrator.java 2
  RestAlarmService.java 2
  BasicAlarmService.java 2
  IncrementalUpdateChecksumsStep.java 2
  HandleObsoleteChecksumsStep.java 2
  HandleMissingFilesStep.java 2
  FullUpdateChecksumsStep.java 2
  StatisticsCollector.java 2
  ReportWriterUtils.java 2
  IntegrityReportProvider.java 2
  DelegatingIntegrityInformationCollector.java 2
  IntegrityDatabase.java 2
  TimerbasedScheduler.java 2
  DatabaseMigrator.java 2
  GetStatusRequestHandler.java 2
  GetAuditTrailsRequestHandler.java 2
  AbstractContributorMediator.java 2
  PagingGetFileIDsClient.java 2
  GetFileIDsCmd.java 2
  GetFileCmd.java 2
  GetChecksumsCmd.java 2
  SelectedComponentInfo.java 2
  PerformingOperationState.java 2
  GeneralConversationState.java 2
  UniqueCommandlineComponentID.java 2
  GettingStatus.java 2
  BlockingGetFileIDsClient.java 2
  GetChecksumsClient.java 2
  BlockingGetChecksumsClient.java 2
  ConversationBasedAuditTrailClient.java 2
  BlockingAuditTrailClient.java 2
  AuditTrailClient.java 2
  MonitoringService.java 2
  ExtractedFileIDsResultSet.java 2
  ExtractedChecksumResultSet.java 2
  IdentifyPillarsForPutFileRequestHandler.java 2
  DeleteFileRequestHandler.java 2
  AuditTrailServiceDAO.java 2
  IncrementalCollector.java 2
  AuditTrailCollector.java 2
  AuditTrailServiceFactory.java 2
  BasicMessageSigner.java 2
  ProtocolComponentFactory.java 2
  SettingsProvider.java 2
  SettingsLoader.java 2
  ChunkyManagedHttpClientConnectionFactory.java 2
  WebclientContextListener.java 2
  ServiceUrlFactory.java 2
  RestMonitoringService.java 2
  ReplacingFile.java 2
  ConversationBasedReplaceFileClient.java 2
  PuttingFile.java 2
  IdentifyPillarsForPutFile.java 2
  BlockingPutFileClient.java 2
  DeletingFile.java 2
  DeleteFileConversationContext.java 2
  ChecksumExtractionUtils.java 2
  GetFileIDsInfoFormatter.java 2
  GetChecksumsInfoFormatter.java 2
  ReplaceFileRequestHandler.java 2
  PillarMediator.java 2
  ReceiverDestinationIDFactory.java 2
  DestinationHelper.java 2
  ModifyComponentFactory.java 2