PMD Results

The following document contains the results of PMD 4.3.

Files

Bitrepository Alarm Service - org/bitrepository/alarm/alarmservice/RestAlarmService.java

Violation Line
Avoid unused private fields such as 'log'. 55

Bitrepository Alarm Service - org/bitrepository/alarm/store/AlarmDatabaseIngestor.java

Violation Line
Too many static imports may lead to messy code 22 - 213

Bitrepository Audit Trail Service - org/bitrepository/audittrails/preserver/AuditPreservationEventHandler.java

Violation Line
Avoid unused private fields such as 'updated'. 48

Bitrepository Audit Trail Service - org/bitrepository/audittrails/store/AuditDatabaseExtractor.java

Violation Line
Too many static imports may lead to messy code 22 - 318

Bitrepository Audit Trail Service - org/bitrepository/audittrails/store/AuditTrailServiceDAO.java

Violation Line
Too many static imports may lead to messy code 22 - 233

Bitrepository Audit Trail Service - org/bitrepository/audittrails/store/AuditTrailServiceDatabaseMigrator.java

Violation Line
Too many static imports may lead to messy code 22 - 113

Bitrepository Client - org/bitrepository/client/AbstractClient.java

Violation Line
Avoid unused private fields such as 'log'. 45

Bitrepository Client - org/bitrepository/client/conversation/StateBasedConversation.java

Violation Line
Avoid unused private fields such as 'log'. 39

Bitrepository Client - org/bitrepository/modify/deletefile/conversation/DeletingFile.java

Violation Line
These nested if statements could be combined 70 - 73

Bitrepository Client - org/bitrepository/modify/putfile/conversation/PuttingFile.java

Violation Line
These nested if statements could be combined 92 - 95
These nested if statements could be combined 186 - 188

Bitrepository Client - org/bitrepository/modify/replacefile/conversation/IdentifyPillarsForReplaceFile.java

Violation Line
Avoid unused local variables such as 'response'. 59

Bitrepository Client - org/bitrepository/modify/replacefile/conversation/ReplacingFile.java

Violation Line
These nested if statements could be combined 74 - 78
These nested if statements could be combined 81 - 85

Bitrepository Core - org/bitrepository/common/utils/FileIDValidator.java

Violation Line
These nested if statements could be combined 73 - 82

Bitrepository Core - org/bitrepository/common/utils/FileUtils.java

Violation Line
These nested if statements could be combined 110 - 113

Bitrepository Core - org/bitrepository/protocol/activemq/ActiveMQMessageBus.java

Violation Line
Avoid unused private methods such as 'addDestinationMessageProducer(String)'. 315
These nested if statements could be combined 409 - 412
These nested if statements could be combined 416 - 419

Bitrepository Core - org/bitrepository/protocol/messagebus/logger/MessageLoggerProvider.java

Violation Line
Avoid unused private fields such as 'log'. 42

Bitrepository Core - org/bitrepository/protocol/security/BasicSecurityManager.java

Violation Line
Avoid empty catch blocks 317 - 319

Bitrepository Core - org/bitrepository/protocol/security/PermissionStore.java

Violation Line
These nested if statements could be combined 102 - 104

Bitrepository Integrity Service - org/bitrepository/integrityservice/cache/IntegrityDatabaseMigrator.java

Violation Line
Avoid unused private fields such as 'UPDATE_SCRIPT_VERSION_1_TO_2'. 44

Bitrepository Integrity Service - org/bitrepository/integrityservice/cache/database/DerbyIntegrityDAO.java

Violation Line
Too many static imports may lead to messy code 1 - 81
Avoid unused imports such as 'java.sql.Connection' 25
Avoid unused imports such as 'java.sql.PreparedStatement' 26
Avoid unused imports such as 'org.bitrepository.service.database.DatabaseUtils' 29

Bitrepository Integrity Service - org/bitrepository/integrityservice/cache/database/IntegrityDAO.java

Violation Line
Too many static imports may lead to messy code 25 - 1580

Bitrepository Integrity Service - org/bitrepository/integrityservice/cache/database/IntegrityDBTools.java

Violation Line
Too many static imports may lead to messy code 1 - 82
An empty statement (semicolon) not part of a loop 78

Bitrepository Integrity Service - org/bitrepository/integrityservice/cache/database/PostgresIntegrityDAO.java

Violation Line
Too many static imports may lead to messy code 1 - 74

Bitrepository Integrity Service - org/bitrepository/integrityservice/web/RestIntegrityService.java

Violation Line
An empty statement (semicolon) not part of a loop 209

Bitrepository Integrity Service - org/bitrepository/integrityservice/workflow/step/UpdateChecksumsStep.java

Violation Line
Avoid unused private fields such as 'settings'. 62

Bitrepository Reference Pillar - org/bitrepository/pillar/cache/ChecksumDAO.java

Violation Line
Avoid unused imports such as 'org.bitrepository.common.settings.Settings' 29

Bitrepository Reference Pillar - org/bitrepository/pillar/cache/database/ChecksumExtractor.java

Violation Line
Too many static imports may lead to messy code 22 - 302

Bitrepository Reference Pillar - org/bitrepository/pillar/cache/database/ChecksumIngestor.java

Violation Line
Too many static imports may lead to messy code 22 - 88

Bitrepository Reference Pillar - org/bitrepository/pillar/checksumpillar/ChecksumPillar.java

Violation Line
Avoid unused imports such as 'org.bitrepository.service.database.DBConnector' 38

Bitrepository Reference Pillar - org/bitrepository/pillar/checksumpillar/messagehandler/IdentifyPillarsForPutFileRequestHandler.java

Violation Line
Avoid unused method parameters such as 'msg'. 151 - 157

Bitrepository Reference Pillar - org/bitrepository/pillar/referencepillar/ReferencePillar.java

Violation Line
Avoid unused imports such as 'org.bitrepository.service.database.DBConnector' 48

Bitrepository Reference Pillar - org/bitrepository/pillar/referencepillar/messagehandler/IdentifyPillarsForPutFileRequestHandler.java

Violation Line
Avoid unused method parameters such as 'msg'. 179 - 184

Bitrepository Service - org/bitrepository/service/audit/AuditTrailContributerDAO.java

Violation Line
Too many static imports may lead to messy code 22 - 431

Bitrepository Service - org/bitrepository/service/contributor/handler/GetStatusRequestHandler.java

Violation Line
Avoid unused method parameters such as 'request'. 115 - 119

Bitrepository Service - org/bitrepository/service/database/SqlScriptRunner.java

Violation Line
Avoid empty if statements 118 - 120
Avoid empty if statements 120 - 122
Avoid empty if statements 122 - 124
Avoid empty catch blocks 176 - 178