[NAS-2731] History/Harveststatus-running.jsp shows malformed webform when using French as GUI languages Created: 09/Apr/18  Updated: 11/Apr/18  Resolved: 11/Apr/18

Status: Resolved
Project: NetarchiveSuite
Component/s: GUI
Affects Version/s: None
Fix Version/s: 5.4

Type: Bug Priority: Blocker
Reporter: Søren Vejrup Carlsen (Inactive) Assignee: Søren Vejrup Carlsen (Inactive)
Resolution: Fixed  
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to NAS-2735 When searching for jobs harvesting a ... Resolved
Spawned
spawned NAS-2733 Show only jobs harvesting domain func... Resolved
Organization:
BNF

 Description   

When using English as GUI language, we get the following webform in the History/Harveststatus-running.jsp page:

<form method="get" name="findJobForDomainForm" action="Harveststatus-running.jsp">
    <input type="hidden" name="searchDone" value="1"/>

    Show only jobs harvesting domain <input type="text"
                   name="DOMAIN_NAME"
                   size="30"
                   value=""/>

    <input type="submit"
           name="search"
           value="Search"/>
</form>

When using French as GUI language
we only get

<form method="get" name="findJobForDomainForm" action="Harveststatus-running.jsp">
    <input type="hidden" name="searchDone" value="1"/>

    

    <input type="submit"
           name="search"
           value="Rechercher"/>
</form>

The text plus input tag corresponding to

 Show only jobs harvesting domain <input type="text"
                   name="DOMAIN_NAME"
                   size="30"
                   value=""/>

is missing from the French version



 Comments   
Comment by Søren Vejrup Carlsen (Inactive) [ 10/Apr/18 ]

The fix has now been committed to the master branch

Comment by Søren Vejrup Carlsen (Inactive) [ 10/Apr/18 ]

The equivalent French one :

Afficher uniquement les jobs qui collectent le domaine {0} 

and Italian one:

Mostra solo i jobs che raccolgono il dominio {0} 
Comment by Søren Vejrup Carlsen (Inactive) [ 10/Apr/18 ]

Have now added a German translation:

Zeige nur Jobs die domain {0} harvesten
Comment by Søren Vejrup Carlsen (Inactive) [ 10/Apr/18 ]

This could be what breaks the page-rendering

Comment by Søren Vejrup Carlsen (Inactive) [ 10/Apr/18 ]

I have identified the problem:
Empty translations of key "running.jobs.finder.inputGroup" for German, French, and Italian:

Translations_da.properties:running.jobs.finder.inputGroup                            = Vis kun jobs der h\u00F8ster dette dom\u00E6ne {0}
Translations_de.properties:running.jobs.finder.inputGroup                            =
Translations_fr.properties:running.jobs.finder.inputGroup                            =
Translations_it.properties:running.jobs.finder.inputGroup                            =
Translations.properties:running.jobs.finder.inputGroup                            = Show only jobs harvesting domain {0}
Comment by Søren Vejrup Carlsen (Inactive) [ 10/Apr/18 ]

In the code itself, we have

<%-- Input field for search --%>
<form method="get" name="findJobForDomainForm" action="Harveststatus-running.jsp">
    <input type="hidden" name="searchDone" value="1"/>

    <fmt:message key="running.jobs.finder.inputGroup">
        <fmt:param>
            <input type="text"
                   name="<%=FindRunningJobQuery.UI_FIELD.DOMAIN_NAME.name()%>"
                   size="30"
                   value=""/>
        </fmt:param>
    </fmt:message>

    <input type="submit"
           name="search"
           value="<fmt:message key="running.jobs.finder.submit"/>"/>
</form>
Generated at Thu May 02 00:09:01 CEST 2024 using Jira 9.4.15#940015-sha1:bdaa9cbecfb6791ea579749728cab771f0dfe90b.