[NAS-2618] Missing I18n numberformatting on some GUI pages Created: 18/Apr/17  Updated: 08/Feb/18  Resolved: 23/May/17

Status: Resolved
Project: NetarchiveSuite
Component/s: GUI, Vienna 2017
Affects Version/s: None
Fix Version/s: 5.3.1

Type: Bug Priority: Minor
Reporter: Søren Vejrup Carlsen (Inactive) Assignee: Søren Vejrup Carlsen (Inactive)
Resolution: Fixed  
Labels: None
Remaining Estimate: Not Specified
Time Spent: 1m
Original Estimate: Not Specified

Attachments: PNG File 1000.png    
Issue Links:
Duplicate
duplicates NASC-69 GB/MB display format Open
Implement
implements NAS-1527 Thousand separators requested in user... Closed
External reference:

https://sbprojects.statsbiblioteket.dk/jira/projects/NARK/issues/NARK-1246
Sprint: NAS 5.3.1
Verification:

Verify that the object sizes on the History/Harveststatus-jobdetails.jsp page are now showed formatted properly according to the language setting

 Description   

The History/Harveststatus-jobdetails.jsp pages are shown unformatted (without '.' or ',')
whereas the History/Harveststatus-perhd.jsp pages as well as the HarvestDefinition/Definitions-edit-domain-config.jsp pages are shown formatted (with '.' or ',')

 Comments   
Comment by Colin Rosenthal [ 08/Feb/18 ]

I've added a screenshot from the latest Stresstest snapshot (en français). It seems to be fine now.

Comment by Søren Vejrup Carlsen (Inactive) [ 05/May/17 ]

Has now been rolled back

Comment by Søren Vejrup Carlsen (Inactive) [ 01/May/17 ]

The version of HarvestStatus-jobdetails.jsp from januar 2016 does not have this issue: https://github.com/netarchivesuite/netarchivesuite/blob/65ee0489bad8609e6f0877f6f852e525d9a5fa38/harvester/history-gui/src/main/webapp/Harveststatus-jobdetails.jsp

So we could roll back to the older version

Comment by Søren Vejrup Carlsen (Inactive) [ 01/May/17 ]

In HarvestStatus-perhd we have this 

<td>
            <fmt:formatNumber type="number"
                              value="<%=hri.getBytesHarvested()%>"/>
        </td>
        <td>
            <fmt:formatNumber type="number"
                              value="<%=hri.getDocsHarvested()%>"/>
        </td>
Comment by Søren Vejrup Carlsen (Inactive) [ 01/May/17 ]

A fix for this is complicated by the fact that most of the code for the History/Harveststatus-jobdetails.jsp lies in the java-class HarvestStatusJobDetails

and lots of out.println commands

Generated at Thu Apr 25 14:00:51 CEST 2024 using Jira 9.4.15#940015-sha1:bdaa9cbecfb6791ea579749728cab771f0dfe90b.