Findbugs Pattern: Method ignores exceptional return value id: RV_RETURN_VALUE_IGNORED_BAD_PRACTICE, type: RV, category: BAD_PRACTICE This method returns a value that is not checked. The return value should be checked since it can indicate an unusual or unexpected function execution. For example, the File.delete() method returns false if the file could not be successfully deleted (rather than throwing an Exception). If you don't check the result, you won't notice if the method invocation signals unexpected behavior by returning an atypical return value. 31 instances of this in netarchivesuite trunk /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/arcrepositoryadmin/UpdateableAdminData.java:275 dk.netarkivet.archive.arcrepositoryadmin.UpdateableAdminData.write() ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/tests/dk/netarkivet/archive/checksum/FileChecksumArchiveTester.java:201 dk.netarkivet.archive.checksum.FileChecksumArchiveTester.testAdminData() ignores exceptional return value of java.io.File.createNewFile() /home/svc/workspace/netarchivesuite/tests/dk/netarkivet/archive/checksum/FileChecksumArchiveTester.java:234 dk.netarkivet.archive.checksum.FileChecksumArchiveTester.testAdminData() ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/arcrepositoryadmin/UpdateableAdminData.java:273 dk.netarkivet.archive.arcrepositoryadmin.UpdateableAdminData.write() ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/harvester/harvesting/frontier/FullFrontierReport.java:419 dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport.parseContentsAsString(String, String) ignores exceptional return value of java.io.File.createNewFile() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/common/utils/FileUtils.java:222 dk.netarkivet.common.utils.FileUtils.remove(File) ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/common/utils/ZipUtils.java:130 dk.netarkivet.common.utils.ZipUtils.unzip(File, File) ignores exceptional return value of java.io.File.mkdir() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/wayback/indexer/ArchiveFile.java:261 dk.netarkivet.wayback.indexer.ArchiveFile.collectResults(BatchStatus) ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/wayback/aggregator/AggregationWorker.java:260 dk.netarkivet.wayback.aggregator.AggregationWorker.handleFinalIndexFileMerge() ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/common/utils/FileUtils.java:829 dk.netarkivet.common.utils.FileUtils$6.close() ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/common/utils/FileUtils.java:684 dk.netarkivet.common.utils.FileUtils.createDir(File) ignores exceptional return value of java.io.File.mkdirs() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/common/utils/FileUtils.java:1183 dk.netarkivet.common.utils.FileUtils.createUniqueTempDir(File, String) ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/wayback/aggregator/AggregationWorker.java:258 dk.netarkivet.wayback.aggregator.AggregationWorker.handleFinalIndexFileMerge() ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/wayback/aggregator/AggregationWorker.java:301 dk.netarkivet.wayback.aggregator.AggregationWorker.rolloverFinalIndexFiles() ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/wayback/aggregator/AggregationWorker.java:216 dk.netarkivet.wayback.aggregator.AggregationWorker.runAggregation() ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/arcrepository/bitpreservation/FileBasedActiveBitPreservation.java:814 dk.netarkivet.archive.arcrepository.bitpreservation.FileBasedActiveBitPreservation.reestablishMissingFile(String, Replica, PreservationState) ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/checksum/FileChecksumArchive.java:235 dk.netarkivet.archive.checksum.FileChecksumArchive.initializeFiles() ignores exceptional return value of java.io.File.mkdir() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/arcrepository/bitpreservation/FileBasedActiveBitPreservation.java:955 dk.netarkivet.archive.arcrepository.bitpreservation.FileBasedActiveBitPreservation.correctArchiveEntry(Replica, String, String, String) ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/common/utils/FileUtils.java:423 dk.netarkivet.common.utils.FileUtils.copyDirectory(File, File) ignores exceptional return value of java.io.File.mkdir() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/deploy/DeployConfiguration.java:192 dk.netarkivet.deploy.DeployConfiguration.copyNetarchiveSuiteFile() ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/webinterface/BatchExecuter.java:126 dk.netarkivet.archive.webinterface.BatchExecuter.run() ignores exceptional return value of java.io.File.createNewFile() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/harvester/harvesting/HarvestDocumentation.java:371 dk.netarkivet.harvester.harvesting.HarvestDocumentation.moveAwayForeignFiles(File, long) ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/common/tools/ReformatTranslationFile.java:76 dk.netarkivet.common.tools.ReformatTranslationFile.main(String[]) ignores exceptional return value of java.io.File.createNewFile() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/arcrepository/bitpreservation/DatabaseBasedActiveBitPreservation.java:190 dk.netarkivet.archive.arcrepository.bitpreservation.DatabaseBasedActiveBitPreservation.reestablishMissingFile(String, Replica) ignores exceptional return value of java.io.File.delete() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/wayback/LRUCache.java:80 new dk.netarkivet.wayback.LRUCache(File, int) ignores exceptional return value of java.io.File.mkdirs() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/indexserver/CDXIndexCache.java:130 dk.netarkivet.archive.indexserver.CDXIndexCache.sortFile(File) ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/tools/RunBatch.java:231 dk.netarkivet.archive.tools.RunBatch$RunBatchTool.checkWriteFile(String, String) ignores exceptional return value of java.io.File.createNewFile() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/bitarchive/distribute/BitarchiveServer.java:160 new dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer() ignores exceptional return value of java.io.File.mkdirs() /home/svc/workspace/netarchivesuite/src/dk/netarkivet/harvester/harvesting/IngestableFiles.java:145 dk.netarkivet.harvester.harvesting.IngestableFiles.setMetadataGenerationSucceeded(boolean) ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/wayback/aggregator/AggregationWorker.java:201 dk.netarkivet.wayback.aggregator.AggregationWorker.runAggregation() ignores exceptional return value of java.io.File.renameTo(File) /home/svc/workspace/netarchivesuite/src/dk/netarkivet/archive/bitarchive/Bitarchive.java:307 dk.netarkivet.archive.bitarchive.Bitarchive.copyRemoteFileToArchive(RemoteFile, String) ignores exceptional return value of java.io.File.delete()