Uploaded image for project: 'NetarchiveSuite'
  1. NetarchiveSuite
  2. NAS-2178

Strange Logic in ArcBatchJob

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • None
    • Archive, Common
    • None

    Description

      The code looks like

      catch (NetarkivetException e) {
                              // Our exceptions don't stop us
                              success = false;
      
                              // With our exceptions, we assume that just the
                              // processing of this record got stopped, and we can
                              // easily find the next
                              handleOurException(e, arcFile, arcFileIndex);
                          } catch (Exception e) {
                              success = false; // Strange exceptions do stop us
      
                              handleException(e, arcFile, arcFileIndex);
                              // With strange exceptions, we don't know
                              // if we've skipped records
                              break;
                          }
      

      But why do we set success=false when handling NetarkivetExceptions? This contradicts the comments and results in the batch job being marked as failed even though we claim to be able to handle this case.

      Attachments

        Activity

          People

            Unassigned Unassigned
            csr Colin Rosenthal
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: