Jonas Lindberg Frellesen

Måske fjern den udkommenterede del?

Måske fjern den udkommenterede del?

Fair nok. Var bare ikke klar over, at vi var begyndt at bruge den notation.

Fair nok.
Var bare ikke klar over, at vi var begyndt at bruge den notation.

Ikke nogen type på hash-settet? allowedOperationPermissions = new HashSet<OperationPermission>();

Ikke nogen type på hash-settet?

allowedOperationPermissions = new HashSet<OperationPermission>();
Followup on CR-BITMAG-381

It seems nice, but all the file-ids it finds starts with the relative path to the folderDir. Thus a FileID = folder1/folder2/file1 will be retrieved as CollectionID/folderDir/folder1/folder2/file1 ...

It seems nice, but all the file-ids it finds starts with the relative path to the folderDir.
Thus a FileID = folder1/folder2/file1
will be retrieved as CollectionID/folderDir/folder1/folder2/file1

This must be an optimization for another day

agreed

agreed

Exactly! But that was not indended. I'll fixed it.

Exactly!
But that was not indended.
I'll fixed it.

Ahh.. Of course. Forgot about the 'validateFileToCacheConsistency...'

Ahh.. Of course. Forgot about the 'validateFileToCacheConsistency...'

ok

ok

Ok, I'll throw an exception here, if it fails

Ok, I'll throw an exception here, if it fails

Where: https://docs.oracle.com/javase/8/docs/api/java/io/File.html#delete-- It might throw an SecurityException, but that's runtime Sure, if we were using the static delete method in the Files uti...

Where:
https://docs.oracle.com/javase/8/docs/api/java/io/File.html#delete--
It might throw an SecurityException, but that's runtime

Sure, if we were using the static delete method in the Files utility class, then it might throw an IOException, but we are using the delete method on the File object itself.

Merge branch 'master' of https://github.com/bitrepository/reference into file_id_issues

Followup on CR-BITMAG-380

  1. … 15 more files in changeset.
Har kigget lidt nærmere på det, og vi behøver slet ikke have collection-id med. Der er ingen grund til at den skal være indlejret i vores exception, da den kun bruges et sted, hvor vi nemt kan skaf...

Har kigget lidt nærmere på det, og vi behøver slet ikke have collection-id med.
Der er ingen grund til at den skal være indlejret i vores exception, da den kun bruges et sted, hvor vi nemt kan skaffe den på en bedre måde.

Jeg tilføjer requesten til loggen i den try-catch, hvor exception'en fanges.

Ja, jeg opdatere det system regex til dit eksempel

Ja, jeg opdatere det system regex til dit eksempel

Ah, ja. Det skal selvfølgelig kun være '..', når det er i form '../' eller '/..' Det retter jeg

Ah, ja. Det skal selvfølgelig kun være '..', når det er i form '../' eller '/..'
Det retter jeg

ok, now I get it. I'll make that case https://sbforge.org/fisheye/static/nhcjlc/2static/images/wiki/icons/emoticons/smile.gif

ok, now I get it.
I'll make that case

agreed

agreed

Partial followup on CR-BITMAG-380

Followup on CR-BITMAG-381

Merge branch 'master' of https://github.com/bitrepository/reference into file_id_issues

I suppose... But yeah, it should be clear what is checked here

I suppose...
But yeah, it should be clear what is checked here

Do you mean: Lists.newArrayList();

Do you mean:

Lists.newArrayList();
Sure, lets do that

Sure, lets do that

agreed, it shouldn't fail silently

agreed, it shouldn't fail silently

but agreed, it shouldn't fail silently

but agreed, it shouldn't fail silently

agreed

agreed