Colin Rosenthal

Minor changes only required (translation)

Minor changes only required (translation)

Correct translation

Correct translation

NAS-2792: Add purple bullet png
NAS-2792: Add purple bullet png
javadoc

javadoc

remove the comments

remove the comments

fix javadoc

fix javadoc

Actually it doesn't matter. The getHost() method will trim the scheme away anyway. However without the scheme, the "getInstance()" method will die. It might be better to add "dummyscheme://" instea...

Actually it doesn't matter. The getHost() method will trim the scheme away anyway. However without the scheme, the "getInstance()" method will die. It might be better to add "dummyscheme://" instead, to show that the scheme doesn't matter.

But not today.

But not today.

Fix this description

Fix this description

finish javadoc

finish javadoc

remove comment.

remove comment.

Using the new StringJoiner utility makes it easier to build a String separated by newlines. Consider the possibility.

Using the new StringJoiner utility makes it easier to build a String separated by newlines. Consider the possibility.

remove these commented lines.

remove these commented lines.

We should try to make the new placeholders more consistent in their naming. I think they should all start with "UMBRA_" so they are easy to find in the cxml.

We should try to make the new placeholders more consistent in their naming. I think they should all start with "UMBRA_" so they are easy to find in the cxml.

javadoc

javadoc

tbh, I thought we'd deleted all these classes from the code. Someone should check in master in case Søren did it after this branch was branched.

tbh, I thought we'd deleted all these classes from the code. Someone should check in master in case Søren did it after this branch was branched.

NAS Umbra Integration
NAS Umbra Integration
Looks good. The "Objective" listed above was modified to, I assume, to be consistent with both Netarkivet and BnF naming conventions - so an option (.*-) prefix before the id.

Looks good. The "Objective" listed above was modified to, I assume, to be consistent with both Netarkivet and BnF naming conventions - so an option (.*-) prefix before the id.

NAS-2514 dns lookup problems
NAS-2514 dns lookup problems
If this is confirmed as the "correct" solution then we should consider making this the only behaviour isntead of having it configurable.

If this is confirmed as the "correct" solution then we should consider making this the only behaviour isntead of having it configurable.

Added the required inline documentation and committed and pushed to master.

Added the required inline documentation and committed and pushed to master.

NAS-2514 "-50" Heritrix Codes
NAS-2514 "-50" Heritrix Codes
Class comment needed.

Class comment needed.

No idea. In Java it wouldn't compile. But if you're interested if(new Object()){out.println("true")}​​​​​​​​​​​ else {out.println("false")}​​ ​if(null){out.println("true")} else {out.println("false...

No idea. In Java it wouldn't compile. But if you're interested

if(new Object()){out.println("true")}​​​​​​​​​​​ else {out.println("false")}​​
​if(null){out.println("true")} else {out.println("false")}
​if(""){out.println("true")} else {out.println("false")}
​if(!""){out.println("true")} else {out.println("false")}
if(".."){out.println("true")} else {out.println("false")}

gives

true
false
false
true
true

!

NAS-2754 Buggy frontier browsing
NAS-2754 Buggy frontier browsing