Bitmagasinet

Bitmagasinet

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,063
Last Commit: 01 Jan 70
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 08 Jun 2017
3:23 pm

Kim Christensen

3:21 pm

Jonas Lindberg Frellesen

3:20 pm

Kim Christensen

Pokkers! Den havde jeg glemt. Gone now

Pokkers! Den havde jeg glemt. Gone now

3:16 pm

Jonas Lindberg Frellesen

Måske fjern den udkommenterede del?

Måske fjern den udkommenterede del?

3:16 pm

Jonas Lindberg Frellesen

Fair nok. Var bare ikke klar over, at vi var begyndt at bruge den notation.

Fair nok.
Var bare ikke klar over, at vi var begyndt at bruge den notation.

3:12 pm

Kim Christensen

Vi gør god brug af 'diamond' notationen rundt omkring. Typen står jo allerede der hvor variablen er erklæret (se linje 82). Finder du det svært at læse?

Vi gør god brug af 'diamond' notationen rundt omkring. Typen står jo allerede der hvor variablen er erklæret (se linje 82). Finder du det svært at læse?

3:03 pm

Jonas Lindberg Frellesen

Ikke nogen type på hash-settet? allowedOperationPermissions = new HashSet<OperationPermission>();

Ikke nogen type på hash-settet?

allowedOperationPermissions = new HashSet<OperationPermission>();
2:32 pm

Kim Christensen

BITMAG-1136 Change permission checking to take collectionID into account when authorizing an...
BITMAG-1136 Change permission checking to take collectionID into account when authorizing an...
Thursday 23 Mar 2017
12:41 pm

Asger Askov Blekinge

SettingsUtils is used non-statically.
SettingsUtils is used non-statically.
Wednesday 08 Mar 2017
11:08 am

Asger Askov Blekinge

Thursday 02 Mar 2017
3:48 pm

Jonas Lindberg Frellesen

3:46 pm

Jonas Lindberg Frellesen

3:37 pm

Jonas Lindberg Frellesen

It seems nice, but all the file-ids it finds starts with the relative path to the folderDir. Thus a FileID = folder1/folder2/file1 will be retrieved as CollectionID/folderDir/folder1/folder2/file1 ...

It seems nice, but all the file-ids it finds starts with the relative path to the folderDir.
Thus a FileID = folder1/folder2/file1
will be retrieved as CollectionID/folderDir/folder1/folder2/file1

This must be an optimization for another day

3:08 pm

Jonas Lindberg Frellesen

agreed

agreed

3:03 pm

Jonas Lindberg Frellesen

Exactly! But that was not indended. I'll fixed it.

Exactly!
But that was not indended.
I'll fixed it.

3:01 pm

Jonas Lindberg Frellesen

Ahh.. Of course. Forgot about the 'validateFileToCacheConsistency...'

Ahh.. Of course. Forgot about the 'validateFileToCacheConsistency...'

3:00 pm

Jonas Lindberg Frellesen

ok

ok

3:00 pm

Jonas Lindberg Frellesen

Ok, I'll throw an exception here, if it fails

Ok, I'll throw an exception here, if it fails

2:58 pm

Jonas Lindberg Frellesen

Where: https://docs.oracle.com/javase/8/docs/api/java/io/File.html#delete-- It might throw an SecurityException, but that's runtime Sure, if we were using the static delete method in the Files uti...

Where:
https://docs.oracle.com/javase/8/docs/api/java/io/File.html#delete--
It might throw an SecurityException, but that's runtime

Sure, if we were using the static delete method in the Files utility class, then it might throw an IOException, but we are using the delete method on the File object itself.

2:41 pm

Jonas Lindberg Frellesen

Har kigget lidt nærmere på det, og vi behøver slet ikke have collection-id med. Der er ingen grund til at den skal være indlejret i vores exception, da den kun bruges et sted, hvor vi nemt kan skaf...

Har kigget lidt nærmere på det, og vi behøver slet ikke have collection-id med.
Der er ingen grund til at den skal være indlejret i vores exception, da den kun bruges et sted, hvor vi nemt kan skaffe den på en bedre måde.

Jeg tilføjer requesten til loggen i den try-catch, hvor exception'en fanges.

2:17 pm

Jonas Lindberg Frellesen

Ja, jeg opdatere det system regex til dit eksempel

Ja, jeg opdatere det system regex til dit eksempel

2:13 pm

Jonas Lindberg Frellesen

Ah, ja. Det skal selvfølgelig kun være '..', når det er i form '../' eller '/..' Det retter jeg

Ah, ja. Det skal selvfølgelig kun være '..', når det er i form '../' eller '/..'
Det retter jeg

2:06 pm

Jonas Lindberg Frellesen

ok, now I get it. I'll make that case https://sbforge.org/fisheye/static/p5xsqj/2static/images/wiki/icons/emoticons/smile.gif

ok, now I get it.
I'll make that case

2:05 pm

Jonas Lindberg Frellesen

agreed

agreed

Wednesday 01 Mar 2017
11:35 am

Asger Askov Blekinge

Okay, I see that you already checked the FileIDFormat in the one user of this method. As to how this can trigger a checksum recalc, let me illustrate: getPillarModel().verifyFileExists(me...

Okay, I see that you already checked the FileIDFormat in the one user of this method.

As to how this can trigger a checksum recalc, let me illustrate: 

        getPillarModel().verifyFileExists(message.getFileID(), message.getCollectionID());
calls
FileStorageModel.verifyFileExists
which calls
StorageModel.hasFileID
which calls
FileStorageModel.verifyFileToCacheConsistencyIfRequired
which calls
FileStorageModel.recalculateChecksum
which calls
...

Need I go on?

11:29 am

Asger Askov Blekinge

Just check rootDir==null initially

Just check rootDir==null initially

11:29 am

Asger Askov Blekinge

This method have all of one user, and he always sends "" as the second param. Consider not having a second param

This method have all of one user, and he always sends "" as the second param. Consider not having a second param

11:28 am

Asger Askov Blekinge

Files.walkFileTree(dir.toPath(), new SimpleFileVisitor<Path>(){ @Override public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) { r...

        Files.walkFileTree(dir.toPath(), new SimpleFileVisitor<Path>(){
            @Override
            public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
                res.add(dirPath+file);
                return FileVisitResult.CONTINUE;
            }
        });
11:11 am

Asger Askov Blekinge

call it createOrGet

call it createOrGet

11:10 am

Asger Askov Blekinge

Fine, call it getOrCreateDirectory. Or getDirectoryFor(retainFile) so you do not have to remember to pass in the parent file.

Fine, call it getOrCreateDirectory. Or getDirectoryFor(retainFile) so you do not have to remember to pass in the parent file.