CR-NAS-372 Bitrepository.java

closed on 10 Apr 19

Author

Moderator

Reviewers

Bitrepository.java

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 9

NetarchiveSuite-Github 0
- Folder archive/archive-core/src/main/java/dk/netarkivet/archive/arcrepository/distribute 0
  - File JMSBitmagArcRepositoryClient.java 34 Remove
- Folder common/common-core/src/main/java/dk/netarkivet/common/distribute/arcrepository/bitrepository 0
  - File BitmagArcRepositoryClient.java 26 Remove
  - File Bitrepository.java 58 Remove
  - File BitrepositoryUtils.java 0 Remove
  - File GetFileIDsListFormatter.java 6 Remove
  - File GetFileIDsNoFormatter.java 2 Remove
  - File HostName.java 8 Remove
  - File NetarchivesuiteBlockingEventHandler.java 5 Remove
  - File TestBitrepository.java 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Asger Askov Blekinge	Author & Moderator	54m	63 (14 defects)	Should not be uncommented. Fixed
Colin Rosenthal	Reviewer - Complete	50m	15	This was placed here instead of the CTOR for reasons. Sho...
Knud Åge Hansen	Reviewer - Complete	4h 50m	16	Delegated instead of relegated - also in the following me...
Jonas Lindberg Frellesen	Reviewer - Complete	3h 15m	47 (16 defects)	agreed, and it should be described in javadoc
Jeppe Ravn-Grove (deleted user)	Reviewer - Complete	1h 12m	1	This class needs cleanup... indentation, removal of unuse...
Total		11h 3m	142 (30 defects)

#permalink

Objectives

DKUPB-207
https://sbprojects.statsbiblioteket.dk/jira/browse/DKUPB-207

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-NAS-372

Bitrepository.java

CR-NAS-372 142

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

Bitrepository.java

CR-NAS-372 142

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time