NAS-2638: Separate H3 monitor into its own modules and fix some errors.

Activity

CR-NAS-355 62

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Nicholas Clarke  (deleted user)
    Author & Moderator 1h 45m 18 Det ligner c++ syntax og jeg gætter på den laver en .toSt...
    Søren Vejrup Carlsen  (deleted user)
    Reviewer completed
    Reviewer - Complete 1h 45m 44 (2 defects) Denne metode kan måske bruges andre steder.Dog er den ikk...
    Total   3h 31m 62 (2 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Søren Vejrup Carlsen  (deleted user)

    Denne kode er blevet merget med master, ikke sandt?

    Denne kode er blevet merget med master, ikke sandt?

    Nicholas Clarke  (deleted user)

    Yes. Og den har lavet lidt rod i crucible ift. de samme filer flere gange og ...

    Yes. Og den har lavet lidt rod i crucible ift. de samme filer flere gange og hvor den ikke helt har styr på de lokale rettelser.

    /common/.../cdx/ArchiveExtractCDXJob.java Changed
    Open in IDE #permalink
    /common/.../webinterface/HTMLUtils.java Changed 2
    /common/.../webinterface/HTMLUtils.java Changed
    /common/.../webinterface/SiteSection.java Changed
    /common/.../webinterface/SiteSection.java Changed
    /deploy/distribution/pom.xml Changed
    Open in IDE #permalink
    /harvester/.../webinterface/HistorySiteSection.java Changed
    Open in IDE #permalink
    /harvester/harvester-core/pom.xml Changed
    Open in IDE #permalink
    /harvester/.../webinterface/HTMLUtilsTester.java Changed
    Open in IDE #permalink
    /harvester/.../webinterface/HTMLUtilsTester.java Changed
    /harvester/.../webinterface/SiteSectionTester.java Changed
    Open in IDE #permalink
    /harvester/.../webinterface/SiteSectionTester.java Changed
    /harvester/.../heritrix3-bundler/pom.xml Changed
    Open in IDE #permalink
    /harvester/.../heritrix3-bundler/pom.xml Changed
    /harvester/.../harvesting/H3LaunchTest.java Changed 2
    Open in IDE #permalink
    /harvester/heritrix3/.../assembly/assembly.xml Added
    Open in IDE #permalink
    /harvester/.../resources/ConfigResource.java Added 1
    Open in IDE #permalink
    /harvester/.../resources/ConfigTemplateBuilder.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3BudgetResource.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3CrawlLogCachedResource.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3FilterResource.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3FrontierDeleteResource.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3FrontierResource.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3JobResource.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3ReportResource.java Added
    Open in IDE #permalink
    /harvester/.../resources/H3ScriptResource.java Added 2
    Open in IDE #permalink
    /harvester/.../resources/H3ScriptTemplateBuilder.java Added 1
    Open in IDE #permalink
    /harvester/.../resources/IndexResource.java Added 5
    Open in IDE #permalink
    /harvester/.../resources/IndexResource.java Changed
    Open in IDE #permalink
    /harvester/.../resources/MasterTemplateBuilder.java Added
    Open in IDE #permalink
    /harvester/.../resources/MasterTemplateBuilder.java Changed
    Open in IDE #permalink
    /harvester/.../monitor/Heritrix3JobMonitor.java Added 5
    /harvester/.../monitor/Heritrix3JobMonitorThread.java Added 9
    /harvester/.../monitor/Heritrix3JobMonitorThread.java Changed
    Open in IDE #permalink
    /harvester/.../monitor/Heritrix3WrapperManager.java Added 2
    Open in IDE #permalink
    /harvester/.../monitor/HistoryServlet.java Added 5
    Open in IDE #permalink
    /harvester/.../monitor/HistoryServlet.java Changed
    Open in IDE #permalink
    /harvester/.../monitor/NASEnvironment.java Added 1
    /harvester/.../monitor/NASEnvironment.java Changed 1
    Open in IDE #permalink
    /harvester/heritrix3/.../monitor/NASUser.java Added 2
    Open in IDE #permalink
    /harvester/heritrix3/.../monitor/Pageable.java Added
    Open in IDE #permalink
    /harvester/.../monitor/Pagination.java Added 2
    Open in IDE #permalink
    /harvester/.../monitor/ResourceAbstract.java Added
    Open in IDE #permalink
    /harvester/.../monitor/ResourceManagerAbstract.java Added
    Open in IDE #permalink
    /harvester/.../monitor/SearchResult.java Added
    Open in IDE #permalink
    /harvester/.../monitor/StringIndexFile.java Added 3
    Open in IDE #permalink
    /harvester/heritrix3/.../monitor/nas.groovy Added 10
    Open in IDE #permalink
    /harvester/heritrix3/.../WEB-INF/web.xml Added
    Open in IDE #permalink
    /harvester/.../css/bootstrap-responsive.css Added
    Open in IDE #permalink
    /harvester/.../css/bootstrap-responsive.min.css Added
    Open in IDE #permalink
    /harvester/heritrix3/.../css/bootstrap.css Added
    Open in IDE #permalink
    /harvester/heritrix3/.../css/bootstrap.min.css Added
    Open in IDE #permalink
    /harvester/.../img/glyphicons-halflings-white.png Added
    Open in IDE #permalink
    /harvester/.../img/glyphicons-halflings.png Added
    Open in IDE #permalink
    /harvester/heritrix3/.../js/bootstrap.js Added
    Open in IDE #permalink
    /harvester/heritrix3/.../js/bootstrap.min.js Added
    Open in IDE #permalink
    /harvester/.../webapp/Monkey-Wrench-icon-16.png Added
    Open in IDE #permalink
    /harvester/.../webapp/Monkey-Wrench-icon-24.png Added
    Open in IDE #permalink
    /harvester/heritrix3/.../webapp/h3config.tpl Added 1
    Open in IDE #permalink
    /harvester/heritrix3/.../webapp/h3script.tpl Added 2
    Open in IDE #permalink
    /harvester/heritrix3/.../webapp/master.tpl Added 2
    Open in IDE #permalink
    /harvester/heritrix3/.../webapp/netarkivet.css Added
    Open in IDE #permalink
    /harvester/.../webapp/transparent_logo.png Added
    Open in IDE #permalink
    /harvester/.../webapp/transparent_menu_logo.png Added
    Open in IDE #permalink
    /harvester/.../heritrix3-monitor/pom.xml Added
    Open in IDE #permalink
    /harvester/.../heritrix3-monitor/pom.xml Changed 2
    Open in IDE #permalink
    /harvester/heritrix3/pom.xml Changed
    Open in IDE #permalink
    /harvester/heritrix3/pom.xml Changed
    /harvester/.../webapp/Harveststatus-running.jsp Changed
    Open in IDE #permalink
    /harvester/history-gui/pom.xml Changed