Removal of H1 support from Netarchivesuite - NAS-2677

CR-NAS-336 4

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 9m 3 (1 defect) The class ./harvester/harvester-core/src/main/java/dk/net...
Reviewer - Complete 2m 1 Not an easy one to review, but should be easy to test. If...
Reviewer - 9% reviewed 14m    
Total   25m 4 (1 defect)  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Søren Vejrup Carlsen

The H1HeritrixTemplate is still present in the harvester-core codebase. Shoul...

The H1HeritrixTemplate is still present in the harvester-core codebase.
Should this be removed as well?

Søren Vejrup Carlsen

It turned out, at the H3 frontier classes depended on the classes in heritrix...

It turned out, at the H3 frontier classes depended on the classes in heritrix1-frontier module, so those have been added to the harvester-core

Søren Vejrup Carlsen

The class ./harvester/harvester-core/src/main/java/dk/netarkivet/harvester/ha...

The class ./harvester/harvester-core/src/main/java/dk/netarkivet/harvester/harvesting/report/Heritrix1Constants.java
should also be removed

  • Defect Classification: Not specified Ranking: Not specified

Colin Rosenthal

Not an easy one to review, but should be easy to test. If it builds and harve...

Not an easy one to review, but should be easy to test. If it builds and harvests then you haven't removed anything vital.

/deploy/deploy-core/pom.xml Changed
Open in IDE #permalink
/deploy/.../standalone/StandaloneApplication.java Deleted
Open in IDE #permalink
/deploy/.../configs/deploy_standalone_debug_example.xml Changed
Open in IDE #permalink
/deploy/distribution/pom.xml Changed
Open in IDE #permalink
/harvester/.../frontier/AbstractFrontierReport.java Added
Open in IDE #permalink
/harvester/.../frontier/AbstractFrontierReportFilter.java Added
Open in IDE #permalink
/harvester/.../frontier/Constants.java Added
Open in IDE #permalink
/harvester/.../frontier/ExhaustedQueuesFilter.java Added
Open in IDE #permalink
/harvester/.../frontier/FrontierReport.java Added
Open in IDE #permalink
/harvester/.../frontier/FrontierReportCsvExport.java Added
Open in IDE #permalink
/harvester/.../frontier/FrontierReportFilter.java Added
Open in IDE #permalink
/harvester/.../frontier/FrontierReportLine.java Added
Open in IDE #permalink
/harvester/.../frontier/FrontierReportLineNaturalOrder.java Added
Open in IDE #permalink
/harvester/.../frontier/FrontierReportLineOrderKey.java Added
Open in IDE #permalink
/harvester/.../frontier/FullFrontierReport.java Added
Open in IDE #permalink
/harvester/.../frontier/InMemoryFrontierReport.java Added
Open in IDE #permalink
/harvester/.../frontier/MaxSizeFrontierReportExtract.java Added
Open in IDE #permalink
/harvester/.../frontier/RetiredQueuesFilter.java Added
Open in IDE #permalink
/harvester/.../frontier/TopTotalEnqueuesFilter.java Added
Open in IDE #permalink
/harvester/harvester-core/pom.xml Changed
Open in IDE #permalink
/harvester/.../controller/AbstractJMXHeritrixController.java Deleted
Open in IDE #permalink
/harvester/.../controller/BnfHeritrixController.java Deleted
Open in IDE #permalink
/harvester/.../controller/BnfHeritrixLauncher.java Deleted
Open in IDE #permalink
/harvester/.../controller/DefaultHeritrixLauncher.java Deleted
Open in IDE #permalink
/harvester/.../controller/FrontierReportAnalyzer.java Deleted
Open in IDE #permalink
/harvester/.../controller/HeritrixController.java Deleted
Open in IDE #permalink
/harvester/.../controller/HeritrixControllerFactory.java Deleted
Open in IDE #permalink
/harvester/.../controller/JMXHeritrixController.java Deleted
Open in IDE #permalink
/harvester/.../distribute/HarvestControllerServer.java Deleted
Open in IDE #permalink
/harvester/.../report/HarvestReportFactory.java Deleted
Open in IDE #permalink
/harvester/.../report/HarvestReportGenerator.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/ArchiveFilesReportGenerator.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HarvestController.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HarvestControllerApplication.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HarvestDocumentation.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/Heritrix1Settings.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HeritrixLauncher.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HeritrixLauncherFactory.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/IngestableFiles.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/package-info.java Deleted
Open in IDE #permalink
/harvester/.../tools/CreateCDXMetadataFile.java Deleted
Open in IDE #permalink
/harvester/.../heritrix1/settings.xml Deleted
Open in IDE #permalink
/harvester/.../externalsoftware/Heritrix1ConstantsTester.java Deleted
Open in IDE #permalink
/harvester/.../externalsoftware/HeritrixTests.java Deleted
Open in IDE #permalink
/harvester/.../externalsoftware/TestInfo.java Deleted
Open in IDE #permalink
/harvester/.../distribute/HarvestControllerServerTester.java Deleted
Open in IDE #permalink
/harvester/.../distribute/TestInfo.java Deleted
Open in IDE #permalink
/harvester/.../report/LegacyHarvestReportTester.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/ArchiveFilesReportGeneratorTest.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HarvestControllerTester.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HarvestDocumentationTester.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/Heritrix1ControllerTestInfo.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HeritrixControllerFactoryTester.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/HeritrixLauncherTester.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/IngestableFilesTester.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/StandaloneHarvester.java Deleted
Open in IDE #permalink
/harvester/.../harvesting/TestInfo.java Deleted
Open in IDE #permalink
/harvester/.../tools/CreateCDXMetadataFileTester.java Deleted
Open in IDE #permalink
/harvester/heritrix1/.../crawldir/heritrix.out Deleted
Open in IDE #permalink
/harvester/.../arcFilesReport/expected.arcfiles-report.txt Deleted
Open in IDE #permalink
/harvester/.../inconsistently-named-arcs/42-117-20051212141240-00000-sb-test-har-001.statsbiblioteket.dk.arc Deleted
Open in IDE #permalink
/harvester/.../inconsistently-named-arcs/43-117-20051212141241-00000-sb-test-har-001.statsbiblioteket.dk.arc Deleted
Open in IDE #permalink
/harvester/.../arcs/42-117-20051212141240-00000-sb-test-har-001.statsbiblioteket.dk.arc Deleted
Open in IDE #permalink
/harvester/.../arcs/42-117-20051212141241-00001-sb-test-har-001.statsbiblioteket.dk.arc Deleted
Open in IDE #permalink
/harvester/.../arcs/not-an-arc-file.txt Deleted
Open in IDE #permalink
/harvester/.../realistically-named-arcs/42-preharvest-metadata-1.arc Deleted
Open in IDE #permalink
/harvester/.../arcs/NetarchiveSuite-netarkivet.arc.gz Deleted
Open in IDE #permalink