NAS-2642: Initial refactoring by making a new method generatePageInformation, which creates a part of...

CR-NAS-334 1

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 47m    
Reviewer - Complete 18m 1 Changes have been merged in with NAS-2638 branch. Fronti...
Total   1h 6m 1  
#permalink

Objectives

  • NAS-2642: Initial refactoring by making a new method generatePageInformation, which creates a part of the HTML-script.
  • NAS-2642: Further refactoring by making a new method generateJobInformation
  • NAS-2642: Refactored a bit more, so it is more clear what actually happens in the methods crawllog_list and frontier_list
  • NAS-2642: An error occured during the refactoring, so a change has been applied that hopefully will fix it
  • NAS-2642: Starting to transfer parameters from crawlog_list to frontier_list
  • NAS-2642: Introducing solution from crawllog
  • NAS-2642: Inserted test in content
  • NAS-2642: Inserted test in content
  • NAS-2642: The pagenumber gets printed as a test
  • NAS-2642: Attempt to only show the specified number of URI's in a first attempt to make it paginated
  • NAS-2642: Inform about the pagenumber and pagesize
  • NAS-2642: Another try to print the pageinformation
  • NAS-2642: Another step towards pagination
  • NAS-2642: Removed adding the pagination to the content variable
  • NAS-2642: Further test regarding pagination
  • NAS-2642: Itemnumber gets printed as test
  • NAS-2642: Another attempt in the pagination process - this time going back to code that should work
  • NAS-2642: Another attempt to reestablish the normal state
  • NAS-2642: Another try to reestablish working code
  • NAS-2642: Another attempt
  • NAS-2642: The first page * 50 items are skipped
  • NAS-2642: Implemented two further parameters in listFrontier
  • NAS-2642: Extracted pagination method variables to class variables so groovy can access them
  • NAS-2642: Reduced the pagesize to 100
  • NAS-2642: Reversed extraction
  • NAS-2642: The first 25 URIs get skipped
  • NAS-2642: Another content is displayed, so the number of pages differs from the number of crawllog pages
  • NAS-2642: Generate frontier paged lines
  • NAS-2642: Refactored
  • NAS-2642: Frontier site divides the number of pending URIs up in pages
  • NAS-2642: Information about page and number of pages is displayed
  • NAS-2642: More information
  • NAS-2642: Changed displayed order of information
  • NAS-2642: Page is set to 2
  • NAS-2642: Further information displayed
  • NAS-2642: Further information displayed
  • NAS-2642: Deleted check on linesPerPage
  • NAS-2642: Back to the old method
  • NAS-2642: Displaying test information
  • NAS-2642: totalCachedSize and totalCachedLines are now set to correct value
  • NAS-2642: The number of the pending URIs is put in the html-string
  • NAS-2642: The number of lines is now determined by pending uris matching the regular expression instead of all pending uris
  • NAS-2642: Since it is necessary to walk through all pending URIs to find out the lines that should be displayed it is also necessary to close the database and then open it again before displaying the actual lines on the page.
  • NAS-2642: Display testinformation
  • NAS-2642: More testinformation
  • NAS-2642: More testinformation
  • NAS-2642: Variable transformation
  • NAS-2642: Testinformation
  • NAS-2642: Testinformation
  • NAS-2642: Now the string is split by #

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Nicholas Clarke

Changes have been merged in with NAS-2638 branch. Frontier groovy function w...

Changes have been merged in with NAS-2638 branch.

Frontier groovy function was 0 paged while the GUI was 1 paged.

Besides the performance issues the solution works.

/harvester/.../servlet/JobResource.java Changed
Open in IDE #permalink
/harvester/.../servlet/nas.groovy Changed
Open in IDE #permalink
/harvester/harvester-core/pom.xml Changed
Open in IDE #permalink
/quickstart-vagrant-environment/run-vagrant.sh Changed
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against