NAS-2646: Modify maven pom.xml to allow for code coverage monitoring

Activity

CR-NAS-333 9

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 25m 8 (2 defects) I don't know. I have created NAS-2700 to look at the issu...
    Reviewer - Complete 14m 1 Is it possible to define the configuration and executions...
    Nicholas Clarke (deleted user)
    Reviewer - 94% reviewed 47m    
    Total   1h 26m 9 (2 defects)  
    #permalink

    Objectives

    After moving from ant to maven, no codecoverage reports have been generated, and thus we're in the dark about the percentage of code covered by our unittests.

    #permalink

    Summary

    No follow-up at this point. Created NAS-2700 to see if we can avoid duplicating the configuration of jacoco in every pom.xml

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Søren Vejrup Carlsen

    Additionally, The Channels.reset() method is now public so it can be used out...

    Additionally, The Channels.reset() method is now public so it can be used outside the common package, After doing this we have removed the ChannelsTesterHelp class, as it is no longer needed.

    Søren Vejrup Carlsen

    A lot of methods in the archive-test had annotation @Ignore without any reaso...

    A lot of methods in the archive-test had annotation @Ignore without any reason. They have now been removed

    Søren Vejrup Carlsen

    Note that a bunch of tests has been moved from archive-test to archive-core. ...

    Note that a bunch of tests has been moved from archive-test to archive-core.
    They are seen as added to archive-core, and deleted from archive-tests

    /archive/.../arcrepositoryadmin/AdminData.java Changed
    Open in IDE #permalink
    /archive/.../distribute/ArcRepositoryServerTester.java Added
    Open in IDE #permalink
    /archive/.../distribute/BatchEndedMessageTester.java Added
    Open in IDE #permalink
    /archive/.../distribute/BitarchiveClientTester.java Added
    Open in IDE #permalink
    /archive/.../distribute/BitarchiveMonitorServerTester.java Added
    Open in IDE #permalink
    /archive/.../distribute/BitarchiveServerTester.java Added
    Open in IDE #permalink
    /archive/.../distribute/GetFileMessageTester.java Added
    Open in IDE #permalink
    /archive/.../distribute/HeartBeatMessageTester.java Added
    Open in IDE #permalink
    /archive/.../distribute/IntegrityTests.java Added
    Open in IDE #permalink
    /archive/.../distribute/TestBatchJobRuns.java Added
    Open in IDE #permalink
    /archive/.../distribute/TestInfo.java Added
    Open in IDE #permalink
    /archive/.../distribute/UploadMessageTester.java Added
    Open in IDE #permalink
    /archive/.../bitarchive/IntegrityTests.java Added
    Open in IDE #permalink
    /archive/archive-core/.../filedir/get1.ARC Added
    Open in IDE #permalink
    /archive/archive-core/.../filedir/get2.ARC Added
    Open in IDE #permalink
    /archive/.../bitarchive1/bitarchive-admin.dat Added
    Open in IDE #permalink
    /archive/.../bitarchive1/bitarchive-credentials.txt Added
    Open in IDE #permalink
    /archive/.../local_files/Upload5.ARC Added
    Open in IDE #permalink
    /archive/.../originals/arc_record0.txt Added
    Open in IDE #permalink
    /archive/.../originals/batch_one_checksum_output.txt Added
    Open in IDE #permalink
    /archive/archive-core/.../originals/file-1.arc Added
    Open in IDE #permalink
    /archive/archive-core/.../originals/file-2.arc Added
    Open in IDE #permalink
    /archive/.../filedir/NetarchiveSuite-upload1.arc Added
    Open in IDE #permalink
    /archive/archive-core/.../filedir/Upload4.ARC Added
    Open in IDE #permalink
    /archive/.../uploadmessage/NetarchiveSuite-store1.arc Added
    Open in IDE #permalink
    /archive/.../uploadmessage/NetarchiveSuite-store2.arc Added
    Open in IDE #permalink
    /archive/archive-core/pom.xml Changed
    Open in IDE #permalink
    /archive/.../bitpreservation/DatabaseBasedActiveBitPreservationTester.java Changed
    Open in IDE #permalink
    /archive/.../bitpreservation/FileBasedActiveBitPreservationTester.java Changed
    Open in IDE #permalink
    /archive/.../distribute/ArcRepositoryServerTester.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/JMSArcRepositoryClientTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ARCLookupTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ArcRepositoryDatabaseTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ArcRepositoryTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ArcRepositoryTesterBatch.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ArcRepositoryTesterGet.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ArcRepositoryTesterStore.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ArcRepositoryTesterStoreChecksum.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/BatchStatusTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/BitarchiveRecordTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/LocalArcRepositoryClientTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/ServerSetUp.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/TestInfo.java Changed
    Open in IDE #permalink
    /archive/.../arcrepository/TrivialArcRepositoryClientTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepositoryadmin/AdminDataTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepositoryadmin/DatabaseAdminTester.java Changed
    Open in IDE #permalink
    /archive/.../arcrepositoryadmin/ReplicaCacheDatabaseTester.java Changed
    Open in IDE #permalink
    /archive/.../distribute/BatchEndedMessageTester.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/BitarchiveClientTester.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/BitarchiveMonitorServerTester.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/BitarchiveServerTester.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/GetFileMessageTester.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/HeartBeatMessageTester.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/IntegrityTests.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/TestBatchJobRuns.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/TestInfo.java Deleted
    Open in IDE #permalink
    /archive/.../distribute/UploadMessageTester.java Deleted
    Open in IDE #permalink
    /archive/.../bitarchive/BatchMessageTester.java Changed 1
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveAdminTester.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveMonitorTester.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveTestCase.java Changed 1
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveTesterAdmin.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveTesterBatch.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveTesterCTOR.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveTesterGet.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveTesterGetFile.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/BitarchiveTesterUpload.java Changed 1
    Open in IDE #permalink
    /archive/.../bitarchive/IntegrityTests.java Deleted
    Open in IDE #permalink
    /archive/.../bitarchive/TestInfo.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/TimeoutBatch.java Changed
    Open in IDE #permalink
    /archive/.../bitarchive/testReflect.java Added 1
    Open in IDE #permalink
    /archive/.../distribute/ChecksumClientTester.java Changed