Review of webdanica development since december

Activity

CR-NAS-332 47

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 1h 38m 25 (7 defects) Jeg forstår ikke hvordan man skal anvende en StringReader...
    Nicholas Clarke (deleted user)
    Reviewer - 78% reviewed 2h 50m 22 Alt det her pjat er væk med ny boilter kode i den version...
    Total   4h 28m 47 (7 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.
    #permalink

    Summary

    Follow-up completed

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nicholas Clarke (deleted user)

    Det er nok en fejl at alle HBase DAO klasserne ikke lukker connection. Kan ik...

    Det er nok en fejl at alle HBase DAO klasserne ikke lukker connection.
    Kan ikke huske om der er en thread local variabel i den klasse der giver en connection tilbage.

    /automatic-workflow/crontab.webdanica Added
    Open in IDE #permalink
    /automatic-workflow/pig16-call-script.sh Changed
    /automatic-workflow/setenv.sh Changed
    /automatic-workflow/verify_pig_bootup.sh Added 2
    Open in IDE #permalink
    /automatic-workflow/webdanica-analysis-cron.sh Changed
    /webdanica-core/src/.../core/criteria/C7.java Changed
    Open in IDE #permalink
    /webdanica-core/src/.../core/criteria/C9.java Changed 2
    Open in IDE #permalink
    /webdanica-core/.../criteria/CombinedCombo.java Changed
    /webdanica-core/src/.../criteria/BitUtils.java Changed
    Open in IDE #permalink
    /webdanica-core/.../criteria/CalcDanishCode.java Changed
    /webdanica-core/.../criteria/Classification.java Added 2
    Open in IDE #permalink
    /webdanica-core/src/.../criteria/Codes.java Changed
    /webdanica-core/.../criteria/CriteriaIngest.java Changed 1
    /webdanica-core/.../criteria/CriteriaUtils.java Changed
    /webdanica-core/.../criteria/DateConverter.java Changed
    /webdanica-core/src/.../criteria/Language.java Changed
    /webdanica-core/src/.../dao/BlackListDAO.java Changed
    Open in IDE #permalink
    /webdanica-core/src/.../dao/CacheDAO.java Changed
    Open in IDE #permalink
    /webdanica-core/.../dao/CassandraCriteriaResultsDAO.java Changed
    /webdanica-core/.../dao/CassandraIngestLogDAO.java Changed
    /webdanica-core/.../dao/CassandraSeedDAO.java Changed
    /webdanica-core/.../dao/HBasePhoenixCacheDAO.java Changed
    /webdanica-core/.../dao/HBasePhoenixDomainsDAO.java Changed 1
    /webdanica-core/.../dao/HBasePhoenixIngestLogDAO.java Changed 2
    /webdanica-core/.../dao/HBasePhoenixSeedsDAO.java Changed 1
    /webdanica-core/src/.../dao/SeedsDAO.java Changed
    /webdanica-core/src/.../datamodel/Cache.java Changed 1
    /webdanica-core/.../datamodel/IngestLog.java Changed
    Open in IDE #permalink
    /webdanica-core/.../datamodel/URL_REJECT_REASON.java Changed 1
    Open in IDE #permalink
    /webdanica-core/.../harvesting/CrawlertrapsUtils.java Added 2
    Open in IDE #permalink
    /webdanica-core/.../harvesting/HarvestLog.java Changed
    /webdanica-core/.../harvesting/SingleSeedHarvest.java Changed 2
    /webdanica-core/.../harvesting/SynchronizeCrawlertraps.java Added
    Open in IDE #permalink
    /webdanica-core/.../filtering/FilterUtils.java Added 2
    /webdanica-core/.../filtering/IgnoredProtocols.java Added 1
    Open in IDE #permalink
    /webdanica-core/.../filtering/IgnoredSuffixes.java Changed
    /webdanica-core/.../filtering/ResolveRedirects.java Changed
    Open in IDE #permalink
    /webdanica-core/.../tools/CheckSettings.java Added
    Open in IDE #permalink
    /webdanica-core/.../tools/FindSubdirOlderThan.java Added 1
    Open in IDE #permalink
    /webdanica-core/.../tools/HarvestShowReports.java Changed 1
    /webdanica-core/src/.../tools/LoadDomains.java Changed
    /webdanica-core/src/.../tools/LoadSeeds.java Changed 1
    /webdanica-core/src/.../tools/LoadTest.java Changed
    /webdanica-core/.../utils/SettingsUtilities.java Changed
    /webdanica-core/src/.../utils/StreamUtils.java Changed 2
    Open in IDE #permalink
    /webdanica-core/.../utils/StringCompressor.java Changed
    Open in IDE #permalink
    /webdanica-core/src/.../utils/SystemUtils.java Changed
    /webdanica-core/src/.../utils/TextUtils.java Changed 1
    Open in IDE #permalink
    /webdanica-core/.../utils/UnitTestUtils.java Changed 2
    /webdanica-core/src/.../utils/UrlUtils.java Changed
    /webdanica-core/.../core/WebdanicaSettings.java Changed
    /webdanica-core/.../cronjobs/check_apps_alive.sh Added
    Open in IDE #permalink
    /webdanica-core/.../cronjobs/cleanup_oldjobs.sh Added
    Open in IDE #permalink
    /webdanica-core/src/.../cronjobs/rebootTomcat Added
    Open in IDE #permalink
    /webdanica-core/.../hbase-phoenix/create_harvests.sql Changed
    /webdanica-core/.../hbase-phoenix/create_ingestlog.sql Changed
    /webdanica-core/.../hbase-phoenix/create_seeds.sql Changed
    /webdanica-core/.../hbase-phoenix/create_statecache.sql Added
    /webdanica-core/.../monitoring/check_apps_alive.sh Deleted
    Open in IDE #permalink
    /webdanica-core/.../criteria/DanishCodeTester.java Added
    Open in IDE #permalink
    /webdanica-core/.../criteria/CriteriaIngestTester.java Changed
    /webdanica-core/.../datamodel/AnalysisStatusTester.java Added
    Open in IDE #permalink
    /webdanica-core/.../datamodel/CriteriaIngestTester.java Changed
    /webdanica-core/.../datamodel/TestHBasePhoenixIngestLogDAO.java Changed
    Open in IDE #permalink