NAS-2520: Groovy scripts from NAS GUI and other monitoring functions...

CR-NAS-307 15

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 1h 5 Max number of running h3 instances. So 80 or so now?
Reviewer - Complete 33m 10 Please the explain the use of constant 42
Total   1h 34m 15  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Nicholas Clarke

So no I18N support currently. Hardcoded strings can be converted for 5.3. The...

So no I18N support currently. Hardcoded strings can be converted for 5.3.
The SiteSection code has been violated slightly since it is hardcoded for JSP only.
Lastly the functionality has been added as a servlet using a template engine instead of JSP. (I really dislike JSP)
Anyway its more like a prototype.

Nicholas Clarke

No javadoc for 5.2 either.

No javadoc for 5.2 either.

Nicholas Clarke

Let the pain begin...

Let the pain begin...

/common/.../webinterface/SiteSection.java Changed
Open in IDE #permalink
/harvester/.../monitor/HarvestMonitor.java Changed
Open in IDE #permalink
/harvester/.../servlet/Heritrix3JobMonitor.java Changed
/harvester/.../servlet/Heritrix3JobMonitorThread.java Changed 2
/harvester/.../servlet/Heritrix3WrapperManager.java Changed 1
Open in IDE #permalink
/harvester/.../servlet/HistoryServlet.java Changed 3
/harvester/.../servlet/IndexResource.java Changed
/harvester/.../servlet/JobResource.java Changed
/harvester/.../servlet/MasterTemplateBuilder.java Added
Open in IDE #permalink
/harvester/.../servlet/NASEnvironment.java Changed 3
Open in IDE #permalink
/harvester/.../servlet/NASUser.java Changed 1
Open in IDE #permalink
/harvester/.../servlet/Pageable.java Changed
Open in IDE #permalink
/harvester/.../servlet/Pagination.java Added 1
Open in IDE #permalink
/harvester/.../servlet/ResourceAbstract.java Added
Open in IDE #permalink
/harvester/.../servlet/ResourceManagerAbstract.java Added
Open in IDE #permalink
/harvester/.../servlet/SearchResult.java Changed 1
Open in IDE #permalink
/harvester/.../servlet/StringIndexFile.java Added
Open in IDE #permalink
/harvester/.../webinterface/HistorySiteSection.java Changed
Open in IDE #permalink
/harvester/.../harvester/HarvesterSettings.java Changed
Open in IDE #permalink
/harvester/.../servlet/nas.groovy Changed
Open in IDE #permalink
/harvester/harvester-core/pom.xml Changed
Open in IDE #permalink
/harvester/history-gui/.../WEB-INF/web.xml Changed
Open in IDE #permalink
/harvester/.../webapp/Harveststatus-running.jsp Changed
Open in IDE #permalink
/harvester/history-gui/.../webapp/h3config.tpl Added
Open in IDE #permalink
/harvester/history-gui/.../webapp/h3script.tpl Changed
/harvester/history-gui/.../webapp/master.tpl Changed
/pom.xml Changed
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against