NAS-2249: FixedDomainConfigurationCountJobGenerator is not thread-safe

Activity

CR-NAS-199 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Nicolas Giraud  (deleted user)
    Author & Moderator      
    Total   0m 0  
    #permalink

    Objectives

    After fixing NAS-2069, revision 2618 (part of NAS-2169 fix) removed synchronized statement from generateJobs in FixedDomainConfigurationCountJobGenerator. But the job generation methods make use of an instance boolean member, so the class is not thread safe anymore.

    In production we had a broad harvest job generation that got intertwined with a focused job generation, resulting in all subsequent broad jobs having the focused configuration count instead of the broad one.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /trunk/.../jobgen/FixedDomainConfigurationCountJobGenerator.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time