NARC-17: Refactor ChannelId access

Activity

CR-NAS-1 15

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Mikis Seth Sørensen  (deleted user)
    Author & Moderator 26m 6 Switching to private constructor
    Søren Vejrup Carlsen  (deleted user)
    Reviewer completed
    Reviewer - Complete 30m 9 (6 defects) Doesn't this make the line more than 80 characters long?
    Total   57m 15 (6 defects)  
    #permalink

    Objectives

    Before the refactored code (see NARC-17: Refactor ChannelId access) is merged to trunk, we need to check that the refactored code is an improvement and that it doesn't break any of the current functionality.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /branches/.../distribute/JMSConnection.java Changed 4
    Open in IDE #permalink
    /branches/.../distribute/JMSConnectionSunMQ.java Changed 1
    Open in IDE #permalink
    /branches/.../distribute/HarvestControllerClient.java Changed 1
    Open in IDE #permalink
    /branches/.../distribute/HarvestControllerServer.java Changed 1
    Open in IDE #permalink
    /branches/.../distribute/JobChannelUtil.java Added 2
    Open in IDE #permalink
    /branches/.../scheduler/HarvestScheduler.java Changed 3
    Open in IDE #permalink
    /branches/.../distribute/ChannelIDTester.java Changed
    Open in IDE #permalink
    /branches/.../distribute/IntegrityTests.java Changed
    Open in IDE #permalink
    /branches/.../distribute/JMSConnectionMockupMQ.java Changed 1
    Open in IDE #permalink
    /branches/.../datamodel/ChannelsGetAnyHacoTester.java Deleted 1
    Open in IDE #permalink
    /branches/.../datamodel/JobChannelUtilTester.java Moved
    Open in IDE #permalink
    /branches/.../distribute/ChannelIDTester.java Changed 1
    Open in IDE #permalink
    /branches/.../distribute/HarvestControllerClientTester.java Changed
    Open in IDE #permalink
    /branches/.../distribute/HarvestControllerServerTester.java Changed
    Open in IDE #permalink
    /branches/.../scheduler/HarvestSchedulerTester.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time