JWAT-9, JWAT-13, JWAT-10, JWAT-40: Gzip multi-part reader/writer bonanza

CR-JWAS-14 27

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 26m 2 Original french code. I opted to rewrite it completely an...
Reviewer - Complete 57m 25 How do you know which it is?
Total   1h 23m 27  
#permalink

Objectives

JWAT-9, JWAT-13, JWAT-10, JWAT-40: Gzip reader/writer working, reporting errors/warnings, unittest covered.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

There are no general comments on this review.
/jwat-arc/src/main/.../jwat/arc/ArcReader.java Changed 1
/jwat-arc/src/.../arc/ArcReaderCompressed.java Changed
/jwat-arc/src/.../arc/ArcReaderFactory.java Changed
/jwat-arc/.../arc/ArcReaderUncompressed.java Changed
/jwat-arc/.../arc/TestArcReaderFactoryCompressed.java Changed 1
/jwat-arc/.../arc/TestArcReaderFactoryUncompressed.java Changed
/jwat-arc/src/.../jwat/arc/TestParams.java Changed
/jwat-common/src/.../common/Diagnosis.java Changed 1
/jwat-common/src/.../common/DiagnosisType.java Added 1
Open in IDE #permalink
/jwat-common/src/.../common/Diagnostics.java Added 1
Open in IDE #permalink
/jwat-common/src/.../common/ISO8859_1.java Added 3
Open in IDE #permalink
/jwat-common/src/.../common/TestISO8859_1.java Added 1
Open in IDE #permalink
/jwat-gzip/src/.../gzip/GzipConstants.java Changed 1
/jwat-gzip/src/.../jwat/gzip/GzipEntry.java Moved 4
/jwat-gzip/src/.../jwat/gzip/GzipEntry.java Deleted
Open in IDE #permalink
/jwat-gzip/src/.../gzip/GzipInputStream.java Deleted
Open in IDE #permalink
/jwat-gzip/src/.../jwat/gzip/GzipReader.java Changed 6
/jwat-gzip/src/.../gzip/GzipReaderEntry.java Deleted
Open in IDE #permalink
/jwat-gzip/src/.../jwat/gzip/GzipWriter.java Changed 2
/jwat-gzip/src/.../gzip/GzipInputStream.java Moved 2
/jwat-gzip/.../gzip/GzipInputStreamEntry.java Moved 1
/jwat-gzip/src/.../gzip/GzipTestHelper.java Added
Open in IDE #permalink
/jwat-gzip/src/.../jwat/gzip/TestEncoding.java Changed
/jwat-gzip/src/.../jwat/gzip/TestFlagged.java Changed
/jwat-gzip/src/.../gzip/TestGzipReader.java Changed
/jwat-gzip/src/.../gzip/TestGzipWriter.java Changed
/jwat-gzip/.../gzip/TestGzipWriterCloning.java Changed
/jwat-gzip/src/.../gzip/TestInputStream.java Changed
/jwat-gzip/.../gzip/TestInputStreamReadSkip.java Changed
/jwat-gzip/src/.../jwat/gzip/TestInvalid.java Changed
/jwat-gzip/src/.../jwat/gzip/TestMagic.java Changed
/jwat-gzip/src/.../jwat/gzip/TestParams.java Changed
/jwat-gzip/src/.../gzip/TestSkippingClose.java Changed
/jwat-warc/src/.../warc/WarcErrorType.java Changed
/jwat-warc/src/.../jwat/warc/WarcReader.java Changed 1
/jwat-warc/.../warc/WarcReaderCompressed.java Changed
/jwat-warc/src/.../warc/WarcReaderFactory.java Changed
/jwat-warc/.../warc/WarcReaderUncompressed.java Changed 1
/jwat-warc/src/.../jwat/warc/WarcRecord.java Changed
/jwat-warc/.../warc/WarcValidationError.java Changed
/jwat-warc/src/.../jwat/warc/TestParams.java Changed
/jwat-warc/.../warc/TestWarcReaderFactoryCompressed.java Changed
/jwat-warc/.../warc/TestWarcReaderFactoryUncompressed.java Changed
/jwat-warc/.../warc/TestWarcWriterCopy.java Changed
/pom.xml Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against