Added unit tests for ARC, WARC and GZip modules. Minor bug fixes also included.

Activity

CR-JHOVE2-IIPC-6 24

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Nicholas Clarke  (deleted user)
    Author 7m    
    Søren Vejrup Carlsen  (deleted user)
    Reviewer completed
    Reviewer - Complete 27m 24 (17 defects) Remove unused beans
    Total   35m 24 (17 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /config/spring/.../warc/jhove2-warc-config.xml Changed 1
    /src/main/.../properties/ArcRecordData.java Changed 1
    /src/main/java/.../format/arc/ArcModule.java Changed
    /src/main/.../format/arc/ArcRecordSource.java Changed 1
    Open in IDE #permalink
    /src/main/java/.../format/gzip/GzipModule.java Changed
    /src/main/java/.../format/warc/WarcModule.java Changed 1
    /src/main/.../warc/WarcRecordSource.java Changed 1
    Open in IDE #permalink
    /src/test/.../format/arc/ArcHeaderTest.java Added
    Open in IDE #permalink
    /src/test/.../format/arc/ArcModuleTest.java Added
    Open in IDE #permalink
    /src/test/.../arc/ArcModuleTestBase.java Added 1
    Open in IDE #permalink
    /src/test/.../arc/ArcRecordBaseTest.java Added 1
    Open in IDE #permalink
    /src/test/.../format/arc/ArcRecordTest.java Added 1
    Open in IDE #permalink
    /src/test/.../arc/ArcVersionBlockTest.java Added 1
    Open in IDE #permalink
    /src/test/.../arc/ArcVersionHeaderTest.java Added 1
    Open in IDE #permalink
    /src/test/.../format/gzip/GzipModuleTest.java Added 1
    Open in IDE #permalink
    /src/test/.../gzip/GzipModuleTestBase.java Added 1
    Open in IDE #permalink
    /src/.../warc/WarcHeaderFieldPolicyTest.java Added 1
    Open in IDE #permalink
    /src/test/.../warc/WarcHeaderVersionTest.java Added 1
    Open in IDE #permalink
    /src/test/.../format/warc/WarcModuleTest.java Added 1
    Open in IDE #permalink
    /src/test/.../warc/WarcModuleTestBase.java Added 2
    Open in IDE #permalink
    /src/.../warc/WarcReaderDiagnosisTest.java Added 1
    Open in IDE #permalink
    /src/test/.../warc/WarcRecordDigestTest.java Added 1
    Open in IDE #permalink
    /src/test/.../format/warc/WarcRecordTest.java Added 1
    Open in IDE #permalink
    /src/test/.../format/arc/arc-test-config.xml Added 1
    Open in IDE #permalink
    /src/test/.../format/gzip/gzip-test-config.xml Added 2
    Open in IDE #permalink
    /src/test/.../format/warc/warc-test-config.xml Added 1
    Open in IDE #permalink
    /src/test/.../arc/invalid-archeader-1.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-archeader-2.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-archeader-3.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-archeader-4.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-archeader-5.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-archeader-6.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-archeader-7.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecord-1.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecord-2.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecord-3.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecordbase-1.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecordbase-2.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecordbase-3.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecordbase-4.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-arcrecordbase-5.arc Added
    Open in IDE #permalink
    /src/test/.../examples/arc/invalid-empty.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-versionblock-1.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-versionblock-10.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-versionblock-11.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-versionblock-2.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-versionblock-3.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-versionblock-4.arc Added
    Open in IDE #permalink
    /src/test/.../arc/invalid-versionblock-5.arc Added
    Open in IDE #permalink