DPA-31: stop ingestion when an error in checksums occours and and write the...

Activity

CR-DPAVISER-14 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Mads Møller Johansen  (deleted user)
    Author 50m 6 Den fik jeg refactureret til noget væsentligt enklere
    Thorbjørn Ravn Andersen  (deleted user)
    Reviewer completed
    Reviewer - Complete 22m 5 file.getAbsolutePath(). Hvis en fil ikke kan findes, vil ...
    Total   1h 13m 11  
    #permalink

    Objectives

    • DPA-31: stop ingestion when an error in checksums occours and and write the errors. Beside of that make sure that there is no files in the batch which is not mentioned in the checksum-file (Except files that is explicitly ignored)


    Jeg havde lavet funktionalitet til at sikre at der ikke eksistere andre filer i et batch end dem der er nævnt i checksums-filen.
    Det lavede jeg efter du havde kommenteret det i et review, men jeg fik aldrig merget det tilbage i master.
    Det var inden vi begyndte at lave branches for hver jira, jeg har valgt at tage det med i denne jira da det er relateret hænger meget sammen.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /newspaper/.../component/RunnablePromptDomsIngester.java Changed
    Open in IDE #permalink
    /newspaper/.../util/BatchMD5SUMSValidation.java Changed 11

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time