Making class for md5Validation in doms-ingester make sure that all files in the...

Activity

CR-DPAVISER-11 10

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 14m 5 Jeg havde det ikke i takterne da jeg lavede det, men jeg ...
    Reviewer - Complete 18m 5 De ser helt ens ud. Kan der evt komme et SIDE 1 og SIDE 2...
    Total   32m 10  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mads Møller Johansen

    Jeg har committet en testavis i dette review, men det er ikke så meget det de...

    Jeg har committet en testavis i dette review, men det er ikke så meget det der er fokus.
    Det væsentlige er den validering jeg har tilføjet til at der er match mellem filer refereret i md5-checksumsfilen og de faktiske filer

    /delivery-samples/.../articles/20160811-verapdf-udgave1-article001.xml Changed
    Open in IDE #permalink
    /delivery-samples/.../articles/20160913-TestAvis-udgave1-article001.xml Added
    Open in IDE #permalink
    /delivery-samples/.../articles/20160913-TestAvis-udgave1-article002.xml Added
    Open in IDE #permalink
    /delivery-samples/.../articles/20160913-TestAvis-udgave1-article003.xml Added
    Open in IDE #permalink
    /delivery-samples/.../pages/20160913-TestAvis-udgave1-page001.pdf Added
    Open in IDE #permalink
    /delivery-samples/.../pages/20160913-TestAvis-udgave1-page001.xml Added
    Open in IDE #permalink
    /delivery-samples/.../pages/20160913-TestAvis-udgave1-page002.pdf Added 1
    Open in IDE #permalink
    /delivery-samples/.../pages/20160913-TestAvis-udgave1-page002.xml Added
    Open in IDE #permalink
    /delivery-samples/B20160913-RT1/MD5SUMS.txt Added
    Open in IDE #permalink
    /delivery-samples/B20160913-RT1/transfer_acknowledged Added
    Open in IDE #permalink
    /delivery-samples/B20160913-RT1/transfer_complete Added
    Open in IDE #permalink
    /newspaper/.../component/RunnablePromptDomsIngester.java Changed
    Open in IDE #permalink
    /newspaper/.../util/BatchMD5Validation.java Changed 8

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against