Pid registration from Henrik ready for Review

CR-DOMS-63 0

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Henrik Schmidt-Møller (deleted user)
Author      
Reviewer - Complete 39m    
Total   39m 0  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

There are no general comments on this review.
/src/main/assembly/assembly.xml Changed
/src/.../config/handleregistrar.properties Deleted
Open in IDE #permalink
/src/main/config/log4j.xml Deleted
Open in IDE #permalink
/src/main/config/pidregistration.log4j.xml Changed
/src/.../config/pidregistration.properties Changed
/src/.../configuration/InitializationFailedException.java Added
Open in IDE #permalink
/src/.../configuration/PropertyBasedRegistrarConfiguration.java Changed
/src/.../configuration/RegistrarConfiguration.java Deleted
Open in IDE #permalink
/src/.../doms/BackendInvalidCredsException.java Added
Open in IDE #permalink
/src/.../doms/BackendInvalidStateException.java Added
Open in IDE #permalink
/src/.../doms/BackendMethodFailedException.java Added
Open in IDE #permalink
/src/main/.../pidregistration/doms/DOMS.java Deleted
Open in IDE #permalink
/src/main/.../doms/DOMSClient.java Added
Open in IDE #permalink
/src/main/.../doms/DOMSMetadata.java Changed
/src/main/.../doms/DOMSMetadataQueryer.java Added
Open in IDE #permalink
/src/main/.../doms/DOMSObjectQueryer.java Changed
/src/main/.../doms/DOMSQueryBuilder.java Deleted
Open in IDE #permalink
/src/main/.../doms/DOMSUpdater.java Added
Open in IDE #permalink
/src/main/.../doms/DomsHandler.java Deleted
Open in IDE #permalink
/src/.../doms/InconsistentDataException.java Deleted
Open in IDE #permalink
/src/main/.../doms/Metadata.java Deleted
Open in IDE #permalink
/src/main/.../doms/RepositoryHandler.java Deleted
Open in IDE #permalink
/src/main/.../handleserver/HandleHandler.java Deleted
Open in IDE #permalink
/src/.../handleserver/PidResolverHandler.java Deleted
Open in IDE #permalink
/src/.../handleserver/PrivateKeyException.java Deleted
Open in IDE #permalink
/src/.../handleserver/RegisteringPidFailedException.java Deleted
Open in IDE #permalink
/src/.../handlesystem/GlobalHandleRegistry.java Changed
/src/.../handlesystem/HandleRequestBuilder.java Added
Open in IDE #permalink
/src/.../handlesystem/PrivateKeyException.java Added
Open in IDE #permalink
/src/.../handlesystem/PrivateKeyLoader.java Changed
Open in IDE #permalink
/src/.../handlesystem/RegisteringPidFailedException.java Added
Open in IDE #permalink
/src/main/.../handlesystem/RequestBuilder.java Deleted
Open in IDE #permalink
/src/.../pidregistration/BackendInvalidCredsException.java Deleted
Open in IDE #permalink
/src/.../pidregistration/BackendMethodFailedException.java Deleted
Open in IDE #permalink
/src/.../pidregistration/BasicHandleRegistrar.java Deleted
Open in IDE #permalink
/src/main/.../pidregistration/Collection.java Changed
/src/main/.../pidregistration/DomsHandler.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleHandler.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleRegistrar.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleRegistrarTool.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleRegistrations.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleRegistrationsTool.java Deleted
Open in IDE #permalink
/src/.../pidregistration/InconsistentDataException.java Deleted
Open in IDE #permalink
/src/.../pidregistration/InitializationFailedException.java Deleted
Open in IDE #permalink
/src/.../pidregistration/PIDDOMSQueryBuilder.java Deleted
Open in IDE #permalink
/src/main/.../pidregistration/PIDHandle.java Changed
Open in IDE #permalink
/src/.../pidregistration/PIDRegistrations.java Changed
/src/.../pidregistration/PIDRegistrationsCommandLineInterface.java Changed
/src/.../pidregistration/PidResolverHandler.java Deleted
Open in IDE #permalink
/src/.../pidregistration/PrivateKeyException.java Deleted
Open in IDE #permalink
/src/.../pidregistration/PropertyBasedRegistrarConfiguration.java Deleted
Open in IDE #permalink
/src/.../pidregistration/RegisteringPidFailedException.java Deleted
Open in IDE #permalink
/src/.../pidregistration/RegistrarConfiguration.java Deleted
Open in IDE #permalink
/src/.../pidregistration/RepositoryHandler.java Deleted
Open in IDE #permalink
/src/.../pidregistration/UnknownCollectionException.java Added
Open in IDE #permalink
/src/main/schemas/centralwebservice.wsdl Added
Open in IDE #permalink
/src/main/schemas/centralwebservice.xsd Added
Open in IDE #permalink
/src/main/scripts/handleregistrartool.sh Deleted
Open in IDE #permalink
/src/.../scripts/handleregistrationstool.sh Deleted
Open in IDE #permalink
/src/main/scripts/pidregistrationtool.sh Added
Open in IDE #permalink
/src/.../configuration/PropertyBasedRegistrarConfigurationTest.java Changed
/src/test/.../doms/CentralWebserviceTest.java Added
Open in IDE #permalink
/src/test/.../doms/DomsHandlerTest.java Deleted
Open in IDE #permalink
/src/test/.../doms/MetadataTest.java Changed
Open in IDE #permalink
/src/.../doms/MockupRepositoryHandler.java Deleted
Open in IDE #permalink
/src/.../handleserver/HandleHandlerTest.java Deleted
Open in IDE #permalink
/src/.../handleserver/MockupPidResolverHandler.java Deleted
Open in IDE #permalink
/src/.../handleserver/PartialMockupHandleHandler.java Deleted
Open in IDE #permalink
/src/.../handlesystem/GlobalHandleRegistryTest.java Changed
/src/.../pidregistration/BasicHandleRegistrarTest.java Deleted
Open in IDE #permalink
/src/.../pidregistration/DomsHandlerTest.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleHandlerTest.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleRegistrarToolTest.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleRegistrationsIntegrationTest.java Deleted
Open in IDE #permalink
/src/.../pidregistration/HandleRegistrationsToolTest.java Deleted
Open in IDE #permalink
/src/.../pidregistration/MockupPidResolverHandler.java Deleted
Open in IDE #permalink
/src/.../pidregistration/MockupRepositoryHandler.java Deleted
Open in IDE #permalink
/src/.../pidregistration/PIDRegistrationsCommandLineInterfaceTest.java Added
Open in IDE #permalink
/src/.../pidregistration/PIDRegistrationsIntegrationTest.java Changed
/src/test/.../pidregistration/PIDTest.java Deleted
Open in IDE #permalink
/src/.../pidregistration/PartialMockupHandleHandler.java Deleted
Open in IDE #permalink
/src/.../pidregistration/PropertyBasedRegistrarConfigurationTest.java Deleted
Open in IDE #permalink
/src/.../resources/0019f31d-b6f7-4ef2-81f6-89b116c64272.xml Added
Open in IDE #permalink
/src/.../resources/001fdf2b-a05a-40de-a43b-787f1ba9041f.xml Added
Open in IDE #permalink
/src/.../resources/4e8a6e1f-b5d1-4e38-8ce8-15c49ce6ca13.xml Added
Open in IDE #permalink
/src/.../resources/bff36b9a-a38e-4cf8-a03a-efe6c7a58f4a.xml Added
Open in IDE #permalink
/src/.../resources/handleregistrar.properties Deleted
Open in IDE #permalink
/src/test/resources/log4j.xml Added
Open in IDE #permalink
/src/.../resources/pidregistration.properties Added
Open in IDE #permalink
/src/test/resources/with.xml Added
Open in IDE #permalink
/src/test/resources/without.xml Added
Open in IDE #permalink
/LICENSE Added
Open in IDE #permalink
/pom.xml Changed
/release-history Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against