BITMAG-297 Update IdentifyPillarsFor*Response with possibility for Error Codes

CR-BITMAG-40 14

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Bolette Ammitzbøll Jurik (deleted user)
Author 1h 11m 8 Response Code 561 (Request was not understood) has been m...
Reviewer - Complete 48m 6 Is 'EXPECTED_SUCCESS' a good name? I would rather conside...
Total   1h 59m 14  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Bolette Ammitzbøll Jurik (deleted user)

IdentifyResponseInfo Complexity sat på dagsordenen https://sbforge.org/displa...

IdentifyResponseInfo Complexity sat på dagsordenen
https://sbforge.org/display/BITMAG/2011-08-31+Videomeeting

Bolette Ammitzbøll Jurik (deleted user)

Who made up the response codes, and what is the principle? Why 4hundred-somet...

Who made up the response codes, and what is the principle? Why 4hundred-something for the positive response codes (and 5hundred-something for the negative ones)?

Bolette Ammitzbøll Jurik (deleted user)

Should ERRORCODE_FINALRESPONSE_TYPE and ERRORCODE_GENERAL_TYPE be merged? I t...

Should ERRORCODE_FINALRESPONSE_TYPE and ERRORCODE_GENERAL_TYPE be merged? I think so! both are now used in FinalResponseCode_TYPE and IdentifyResponseCode_TYPE.

Alternatively we can merge FinalResponseCode_TYPE and IdentifyResponseCode_TYPE. But this would mean that we either allow both value="480" (Message request has been completed successfully) and value="440"> (Message request has been received and operation request is expected to be successful) as positive response codes though only one of them makes sense, OR we make just one positive response code, which has different meanings depending on which message it occurs in. I don't like any of these, so I recommend leaving FinalResponseCode_TYPE and IdentifyResponseCode_TYPE as different types.

Bolette Ammitzbøll Jurik (deleted user)

Response Code 561 (Request was not understood) has been moved to ERRORCODE_GE...

Response Code 561 (Request was not understood) has been moved to ERRORCODE_GENERAL_TYPE, and IdentifyResponseCode_TYPE no longer includes ERRORCODE_FINALRESPONSE_TYPE.

/trunk/.../messages/GetAuditTrailsFinalResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/GetAuditTrailsProgressResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyContributorsForGetAuditTrailsResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyContributorsForGetStatusResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyPillarsForDeleteFileResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyPillarsForGetChecksumsResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyPillarsForGetFileIDsResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyPillarsForGetFileResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyPillarsForPutFileResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/IdentifyPillarsForReplaceFileResponse.xml Changed
Open in IDE #permalink
/trunk/.../messages/PutFileFinalResponse.xml Changed
Open in IDE #permalink
/trunk/.../xsd/BitRepositoryElements.xsd Changed 3
Open in IDE #permalink
/trunk/.../xsd/BitRepositoryMessages.xsd Changed 2
Open in IDE #permalink
/trunk/.../xjb-bindings/bindings.xjb Changed 2
Open in IDE #permalink
/trunk/.../protocol/TestMessageFactory.java Changed 3
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against