Sorry, Jonas, this is ABRs review comments to 373

Activity

CR-BITMAG-381 56

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 56m 28 (2 defects) Okay, I see that you already checked the FileIDFormat in ...
    Reviewer - 94% reviewed 18m 4 So the file "hej Jonas..doc" will not be allowed? https:/...
    Reviewer - Complete 1h 6m 24 It seems nice, but all the file-ids it finds starts with ...
    Total   2h 20m 56 (2 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /bitrepository-core/.../utils/FileUtils.java Changed 11
    Open in IDE #permalink
    /bitrepository-core/.../utils/ListUtils.java Deleted
    Open in IDE #permalink
    /bitrepository-core/.../utils/FileUtilsTest.java Changed
    Open in IDE #permalink
    /bitrepository-core/.../utils/TestFileHelper.java Changed 2
    Open in IDE #permalink
    /bitrepository-reference-pillar/.../messagehandler/GetChecksumsRequestHandler.java Changed 4
    /bitrepository-reference-pillar/.../messagehandler/GetFileIDsRequestHandler.java Changed 2
    /bitrepository-reference-pillar/.../messagehandler/IdentifyPillarsForGetFileRequestHandler.java Changed 5
    /bitrepository-reference-pillar/.../messagehandler/PillarMessageHandler.java Changed 2
    /bitrepository-reference-pillar/.../messagehandler/PutFileRequestHandler.java Changed
    /bitrepository-reference-pillar/.../filearchive/ArchiveDirectory.java Changed 30
    Open in IDE #permalink
    /bitrepository-reference-pillar/.../filearchive/ReferenceArchive.java Changed
    Open in IDE #permalink
    /bitrepository-reference-pillar/.../messagehandling/GeneralMessageHandlingTest.java Changed
    /bitrepository-reference-pillar/.../archive/ArchiveDirectoryTest.java Changed
    Open in IDE #permalink
    /bitrepository-reference-pillar/.../conf/RepositorySettings.xml Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against