Followup on the file id issue discussion at last meeting. Thus handling of file...

Activity

CR-BITMAG-380 53

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 18m 18 Har kigget lidt nærmere på det, og vi behøver slet ikke h...
    Reviewer - 66% reviewed 31m 7 As for the Quickstart, it does not work on Windows, and t...
    Reviewer - Complete 51m 28 (3 defects) I do NOT like chars such as & in my unix filenames. * is ...
    Total   2h 40m 53 (3 defects)  
    #permalink

    Objectives

    • Followup on the file id issue discussion at last meeting. Thus handling of file ids starting with '/' and containing '..'. Also fixed issue, where the regex was tested but the results where ignored. And made tests for it.
    • Merge branch 'master' of https://github.com/bitrepository/reference into file_id_issues
    • Small update to test, which caught a minor issue.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /bitrepository-core/.../bitrepository-devel/RepositorySettings.xml Changed 5
    Open in IDE #permalink
    /bitrepository-reference-pillar/.../messagehandler/DeleteFileRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/GetChecksumsRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/GetFileIDsRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/GetFileRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/IdentifyPillarsForDeleteFileRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/IdentifyPillarsForGetChecksumsRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/IdentifyPillarsForGetFileIDsRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/IdentifyPillarsForGetFileRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/IdentifyPillarsForPutFileRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/IdentifyPillarsForReplaceFileRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/PillarMessageHandler.java Changed 9
    /bitrepository-reference-pillar/.../messagehandler/PutFileRequestHandler.java Changed 1
    /bitrepository-reference-pillar/.../messagehandler/ReplaceFileRequestHandler.java Changed 4
    /bitrepository-reference-pillar/.../messagehandling/GeneralMessageHandlingTest.java Changed 16
    /bitrepository-reference-pillar/.../conf/RepositorySettings.xml Changed 8
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against