Initial dashboard checking

Activity

CR-BITMAG-241 19

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author      
    Mikis Seth Sørensen  (deleted user)
    Reviewer completed
    Reviewer - Complete 27m 13 -> engelsk
    Reviewer - Complete 47m 6 Arh.. Mikis have added them (on my behalf)
    Total   1h 15m 19  
    #permalink

    Objectives

    Intial review of Thomas's dashboard implementation.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mikis Seth Sørensen  (deleted user)

    Not many methods are documented. All public and protected metods/classes shou...

    Not many methods are documented. All public and protected metods/classes should at least be documented.

    Mikis Seth Sørensen  (deleted user)

    Koden er engelskbaseret, dvs. vi skal have ændret danske inspiret ord til eng...

    Koden er engelskbaseret, dvs. vi skal have ændret danske inspiret ord til engelsk.

    Kim Christensen

    Most of the jsp pages can be trivially 'translated' into javascript. Which wo...

    Most of the jsp pages can be trivially 'translated' into javascript. Which would be a better fit into the rest of the code base. "tilvaekst.jsp" seems like the only one with much processing and could be subsituted with a webservice call delivering the needed data.
    So I hope that this is only a temporary state for the code.

    /bitrepository-webclient/.../dashboard/DashboardDataCache.java Added 4
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard/DashboardServlet.java Added 2
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard/FileSizeUtils.java Added 1
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard/GetCollectionInformation.java Added 1
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard/GetIntegrityStatus.java Added
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard/GetWorkflowSetup.java Added
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard/IntegrityClient.java Added
    Open in IDE #permalink
    /bitrepository-webclient/.../webservice/ServiceUrl.java Changed
    /bitrepository-webclient/.../resources/services.properties Changed
    /bitrepository-webclient/.../WEB-INF/web.xml Changed
    /bitrepository-webclient/.../dashboard_components/data_ben_tb.jsp Added
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard_components/pop_up_script.jsp Added 1
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard_components/procedurer_for_kontrol.jsp Added
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard_components/samlinger_status.jsp Added
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard_components/samlinger_tb.jsp Added
    Open in IDE #permalink
    /bitrepository-webclient/.../dashboard_components/tilvaekst.jsp Added
    /bitrepository-webclient/.../flot/excanvas.js Added
    Open in IDE #permalink
    /bitrepository-webclient/.../flot/jquery.flot.axislabels.js Added
    Open in IDE #permalink
    /bitrepository-webclient/.../flot/jquery.flot.min.js Added
    Open in IDE #permalink
    /bitrepository-webclient/.../flot/jquery.flot.pie.min.js Added
    Open in IDE #permalink
    /bitrepository-webclient/.../flot/jquery.flot.selection.min.js Added
    Open in IDE #permalink
    /bitrepository-webclient/.../webapp/bitrepository-frontpage.jsp Changed
    /bitrepository-webclient/.../webapp/dashboard.jsp Added 7
    Open in IDE #permalink
    /bitrepository-webclient/.../webapp/menu.js Changed
    /bitrepository-webclient/pom.xml Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time