NetarchiveSuite-Github

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
NAS-2702: The jobgeneration of Snapshot harvests using the DefaultJobGenerator.java generates too many jobs
NAS-2702: The jobgeneration of Snapshot harvests using the DefaultJobGenerator.java generates too many jobs
This code also fixes the synchronization bug in the HarvestJobGenerator (NAS-2682). The last run of this code before the last commit generated 1954 jobs instead of 2099 which is not the result we ...

This code also fixes the synchronization bug in the HarvestJobGenerator (NAS-2682).

The last run of this code before the last commit generated 1954 jobs instead of 2099
which is not the result we aimed for.
The last commit tries to improve on that with some optimization

In this "else" clause isn't read==s.length() ? So can't you always write s.length() chars?

In this "else" clause isn't read==s.length() ? So can't you always write s.length() chars?

NAS-2701: StreamUtils.getInputStreamAsString() and StreamUtils.copyInputStreamToJspWriter() throw IndexOutOfBounds exceptions
NAS-2701: StreamUtils.getInputStreamAsString() and StreamUtils.copyInputStreamToJspWriter() throw IndexOutOfBounds exceptions
Fixed NAS-2687 (indexing fix) in master bracnch
Fixed NAS-2687 (indexing fix) in master bracnch
NAS-2694 Site Section not loading
NAS-2694 Site Section not loading
No follow-up at this point. Created NAS-2700 to see if we can avoid duplicating the configuration of jacoco in every pom.xml

No follow-up at this point. Created NAS-2700 to see if we can avoid duplicating the configuration of jacoco in every pom.xml

I don't know. I have created NAS-2700 to look at the issue later

I don't know. I have created NAS-2700 to look at the issue later

magic numbers: 2,7,8

magic numbers: 2,7,8

Hvad bruges variablen tmpPage til?

Hvad bruges variablen tmpPage til?

Skal alt det udkommenterede kode ikke bare fjernes?

Skal alt det udkommenterede kode ikke bare fjernes?

Follow-up completed

Follow-up completed

But you're right about the method-name. I have changed the method setMetadataGenerationSucceeded(true) to closeMetadataFile() and added a setErrorState to use for the call with argument false in th...

But you're right about the method-name.
I have changed the method setMetadataGenerationSucceeded(true) to closeMetadataFile()
and added a setErrorState to use for the call with argument false in the finally clause

Fixed in commit: https://github.com/netarchivesuite/netarchivesuite/commit/b37c2daeab0c3071ae9e1ce1774c585f85c40c40

NAS-2641: In H3 Remote Access, the Next/Previous regex search in crawllogs doesn't work
NAS-2641: In H3 Remote Access, the Next/Previous regex search in crawllogs doesn't work
Not correct. If argument is true, it closes the MetadataFileWriter,and moves the Metadata-file from the 'tmp-meta' folder to the 'metadata' folder

Not correct. If argument is true, it closes the MetadataFileWriter,and moves the Metadata-file from the 'tmp-meta' folder to the 'metadata' folder

All follow-up completed

All follow-up completed

Fixed in commit https://github.com/netarchivesuite/netarchivesuite/commit/3f8f6b38909e38ea19041aa99ce90c8712438b83
fixed in commit https://github.com/netarchivesuite/netarchivesuite/commit/c30b94031c8613cea5876a5af588d98f46fb21e4
Follow-up completed

Follow-up completed

Closing review. No followup required

Closing review. No followup required