NetarchiveSuite-Github

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
replace with isTreatDnsLikeHttp()

replace with isTreatDnsLikeHttp()

NAS-2514 dns lookup problems
NAS-2514 dns lookup problems
If this is confirmed as the "correct" solution then we should consider making this the only behaviour isntead of having it configurable.

If this is confirmed as the "correct" solution then we should consider making this the only behaviour isntead of having it configurable.

Added the required inline documentation and committed and pushed to master.

Added the required inline documentation and committed and pushed to master.

Note that this means that fetching of prerequisites is always allowed

Note that this means that fetching of prerequisites is always allowed

NAS-2514 "-50" Heritrix Codes
NAS-2514 "-50" Heritrix Codes
Class comment needed.

Class comment needed.

No idea. In Java it wouldn't compile. But if you're interested if(new Object()){out.println("true")}​​​​​​​​​​​ else {out.println("false")}​​ ​if(null){out.println("true")} else {out.println("false...

No idea. In Java it wouldn't compile. But if you're interested

if(new Object()){out.println("true")}​​​​​​​​​​​ else {out.println("false")}​​
​if(null){out.println("true")} else {out.println("false")}
​if(""){out.println("true")} else {out.println("false")}
​if(!""){out.println("true")} else {out.println("false")}
if(".."){out.println("true")} else {out.println("false")}

gives

true
false
false
true
true

!

All followup committed, now

All followup committed, now

agreed

agreed

When is the former statement true?

When is the former statement true?

NAS-2754 Buggy frontier browsing
NAS-2754 Buggy frontier browsing
Not sure why code uses compareTo() instead of equals() (maybe a groovy thing) so I didn't mess with it.

Not sure why code uses compareTo() instead of equals() (maybe a groovy thing) so I didn't mess with it.

This is still not quite right because a ".*" can give more than the page size. But good enough for now IMO.

This is still not quite right because a ".*" can give more than the page size. But good enough for now IMO.

No follow-up required

No follow-up required

NAS-2752: We always look for duplicationmigration records during indexing
NAS-2752: We always look for duplicationmigration records during indexing
Have now moved it to a finally clause

Have now moved it to a finally clause

I have now changed the code to only catch an Exception in the last catch phrase

I have now changed the code to only catch an Exception in the last catch phrase

Do we want to catch Throwable here or just Exception? We've recently seen bad behaviour as a consequence of catching OOM's.

Do we want to catch Throwable here or just Exception? We've recently seen bad behaviour as a consequence of catching OOM's.

Shouldn't this be in a finally clause?

Shouldn't this be in a finally clause?

It might be a good idea to renew the jmsConnection object in the same go: jmsConnection = null; qSession = null; and then add a if (jmsConnection == null) { jmsConnection = JMSConnectionFactor...

It might be a good idea to renew the jmsConnection object in the same go:

jmsConnection = null;
qSession = null;

and then add a

 
if (jmsConnection == null) {
  jmsConnection = JMSConnectionFactory.getInstance();
}

before the "if (qSession == null)" clause

NAS-2751: The HarvestStatusReceiver.getCount method has a memoryLeak
NAS-2751: The HarvestStatusReceiver.getCount method has a memoryLeak
Should really delete the method createQueueBrowser(ChannelID queueID) which creates a QueueSession every time the method is called unless of course we should cache a QueueBrowser for every queueID,...

Should really delete the method createQueueBrowser(ChannelID queueID) which creates a QueueSession every time the method is called
unless of course we should cache a QueueBrowser for every queueID, we see?

This change is strictly not necessary anymore. It was part of my attempt at having a separate JMSConnection for the QueueController rather than just using the JMSConnectionFactory.getInstance() method

This change is strictly not necessary anymore.
It was part of my attempt at having a separate JMSConnection for the QueueController rather than just using
the JMSConnectionFactory.getInstance() method