NetarchiveSuite-Github

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This means that the ORDER BY clause must go away; otherwise it is not valid sql. This could be an issue.

This means that the ORDER BY clause must go away; otherwise it is not valid sql.
This could be an issue.

This code needs to be changed to return the best match of the found entries

This code needs to be changed to return the best match of the found entries

It turns out that the "SELECT domains.name" must be "SELECT DISTINCT domains.name" or there will be duplicate entries

It turns out that the "SELECT domains.name" must be "SELECT DISTINCT domains.name" or there will be duplicate entries

add missing javadoc

add missing javadoc

This should probably be at log.trace

This should probably be at log.trace

same here: This should probably be at log.trace

same here: This should probably be at log.trace

This should probably be at log.trace

This should probably be at log.trace

NAS-2704: Typo and wrong default value for setting settings.harvester.scheduler.jobgenerationperiode
NAS-2704: Typo and wrong default value for setting settings.harvester.scheduler.jobgenerationperiode
Confusion. Deception. World Domination!

Confusion. Deception. World Domination!

Only if you do naughty custom implementations.

Only if you do naughty custom implementations.

No follow-up needed

No follow-up needed

Consider having two classes HttpLocale and HttpLocaleHandler

Consider having two classes HttpLocale and HttpLocaleHandler

Maybe HttpLocaleHandler a better name than HttpLocaleUtils

Maybe HttpLocaleHandler a better name than HttpLocaleUtils

missing javadoc

missing javadoc

What is the use of this class?

What is the use of this class?

add javadoc

add javadoc

Missing javadoc

Missing javadoc

Indentation is wrong Missing javadoc

Indentation is wrong
Missing javadoc

Missing param 'req' in javadoc

Missing param 'req' in javadoc

Is context.getRequest() never anything else than a HttpServletRequest object ?

Is context.getRequest() never anything else than a HttpServletRequest object ?

Missing param 'req' in javadoc

Missing param 'req' in javadoc

Missing parameters in javadoc: req, subMenu

Missing parameters in javadoc: req, subMenu

spelling: Navifation => Navigation

spelling: Navifation => Navigation

NAS-2647: Improved locale support in HistoryServlet
NAS-2647: Improved locale support in HistoryServlet
Closing review - no further followup required

Closing review - no further followup required

I have now tested this hypothesis, and found that it was faulty. Only If s.length() < read is it ok to use s.length() as the value.

I have now tested this hypothesis, and found that it was faulty.
Only If s.length() < read is it ok to use s.length() as the value.

I believe we can, as s.length will always be <= 'read', so we can eliminate the if-else altogther, and just write out.write(s,0, s.length());

I believe we can, as s.length will always be <= 'read', so we can eliminate the if-else altogther, and just write
out.write(s,0, s.length());

NAS-2702: The jobgeneration of Snapshot harvests using the DefaultJobGenerator.java generates too many jobs
NAS-2702: The jobgeneration of Snapshot harvests using the DefaultJobGenerator.java generates too many jobs
This code also fixes the synchronization bug in the HarvestJobGenerator (NAS-2682). The last run of this code before the last commit generated 1954 jobs instead of 2099 which is not the result we ...

This code also fixes the synchronization bug in the HarvestJobGenerator (NAS-2682).

The last run of this code before the last commit generated 1954 jobs instead of 2099
which is not the result we aimed for.
The last commit tries to improve on that with some optimization