NetarchiveSuite-Github

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Review closed

Review closed

The objective above is of course wrong as it stands. To comply with the BNF and legacy naming scheme, we ended up with // Same pattern here as defined in class dk.netarkivet.viewerproxy.webinterf...

The objective above is of course wrong as it stands.
To comply with the BNF and legacy naming scheme, we ended up with

 // Same pattern here as defined in class dk.netarkivet.viewerproxy.webinterface.Reporting
 final String specifiedPattern = "(.*-)?" + id + "(-.*)?" + metadataFilePatternSuffix;
Looks good. The "Objective" listed above was modified to, I assume, to be consistent with both Netarkivet and BnF naming conventions - so an option (.*-) prefix before the id.

Looks good. The "Objective" listed above was modified to, I assume, to be consistent with both Netarkivet and BnF naming conventions - so an option (.*-) prefix before the id.

Closing review. No followup needed

Closing review.
No followup needed

NAS-2760: Remove obsolete heritrix 1 files from distribution
NAS-2760: Remove obsolete heritrix 1 files from distribution
NAS-2712: Indexserver includes too much in the specifiedPattern used by RawMetadataCache#cacheData(Long id)
NAS-2712: Indexserver includes too much in the specifiedPattern used by RawMetadataCache#cacheData(Long id)
I believe this is part of 5.4.2 now, so we might as well close this after a quick review

I believe this is part of 5.4.2 now, so we might as well close this after a quick review

replace with isTreatDnsLikeHttp()

replace with isTreatDnsLikeHttp()

NAS-2514 dns lookup problems
NAS-2514 dns lookup problems
If this is confirmed as the "correct" solution then we should consider making this the only behaviour isntead of having it configurable.

If this is confirmed as the "correct" solution then we should consider making this the only behaviour isntead of having it configurable.

Added the required inline documentation and committed and pushed to master.

Added the required inline documentation and committed and pushed to master.

Note that this means that fetching of prerequisites is always allowed

Note that this means that fetching of prerequisites is always allowed

NAS-2514 "-50" Heritrix Codes
NAS-2514 "-50" Heritrix Codes
Class comment needed.

Class comment needed.

No idea. In Java it wouldn't compile. But if you're interested if(new Object()){out.println("true")}​​​​​​​​​​​ else {out.println("false")}​​ ​if(null){out.println("true")} else {out.println("false...

No idea. In Java it wouldn't compile. But if you're interested

if(new Object()){out.println("true")}​​​​​​​​​​​ else {out.println("false")}​​
​if(null){out.println("true")} else {out.println("false")}
​if(""){out.println("true")} else {out.println("false")}
​if(!""){out.println("true")} else {out.println("false")}
if(".."){out.println("true")} else {out.println("false")}

gives

true
false
false
true
true

!

All followup committed, now

All followup committed, now

agreed

agreed

When is the former statement true?

When is the former statement true?

NAS-2754 Buggy frontier browsing
NAS-2754 Buggy frontier browsing
Not sure why code uses compareTo() instead of equals() (maybe a groovy thing) so I didn't mess with it.

Not sure why code uses compareTo() instead of equals() (maybe a groovy thing) so I didn't mess with it.

This is still not quite right because a ".*" can give more than the page size. But good enough for now IMO.

This is still not quite right because a ".*" can give more than the page size. But good enough for now IMO.

No follow-up required

No follow-up required