larm-doms-exporter

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Doms Larm export får kanal med
Doms Larm export får kanal med
have changed implementation, so process will terminate if missing entries

have changed implementation, so process will terminate if missing entries

changed implementation to throw exception

changed implementation to throw exception

javadoc has been corrected

javadoc has been corrected

javadoc has been added

javadoc has been added

We should check here that the new ChaosChannelEntity has a non-null display-name and logo.

We should check here that the new ChaosChannelEntity has a non-null display-name and logo.

I would suggest that we have at least one test that reads the main channelmappings file from src to test that it parses ok. Maybe we don't really need this file in test?

I would suggest that we have at least one test that reads the main channelmappings file from src to test that it parses ok. Maybe we don't really need this file in test?

Remember to include release notes as a .md file as part of the codebase.

Remember to include release notes as a .md file as part of the codebase.

Maybe define an interface for this class.

Maybe define an interface for this class.

Need to do something more than print stack trace here. Should probably log the output as error and rethrow as a runtime exception. There's no way to recover from these exceptions so they should kil...

Need to do something more than print stack trace here. Should probably log the output as error and rethrow as a runtime exception. There's no way to recover from these exceptions so they should kill the application

Add some explanatory javadoc for this hashmap - ie what the key means.

Add some explanatory javadoc for this hashmap - ie what the key means.

Correct class javadoc

Correct class javadoc

NO-273: extended export to also handle TV channels; before only Radio channels were exported. Mapping...
NO-273: extended export to also handle TV channels; before only Radio channels were exported. Mapping...
A certain amount of cleaning up carried out and some "TODOs" scattered in the code for later attention.

A certain amount of cleaning up carried out and some "TODOs" scattered in the code for later attention.

Agreed, and have added a TODO. Requires some minor refactoring to make a "nice" test possible - basically injection of an OutputStream so we don't necessarily write to a file.

Agreed, and have added a TODO. Requires some minor refactoring to make a "nice" test possible - basically injection of an OutputStream so we don't necessarily write to a file.

Create an earlier processor to set an OutputStream in the state object. This will make this code easier to test as it won't have to write to the filesystem.

Create an earlier processor to set an OutputStream in the state object. This will make this code easier to test as it won't have to write to the filesystem.

Add a unit test for this method.

Add a unit test for this method.

Quite. I wrote this message guessing from the class names. The one I really should have mentioned was DoExportProcessor, I think.

Quite. I wrote this message guessing from the class names.
The one I really should have mentioned was DoExportProcessor, I think.

Why? It's just a bean class with getters and setters.

Why? It's just a bean class with getters and setters.

I can't find any uses of either of these files.

I can't find any uses of either of these files.

If it's not to be at Geckon's end then the correct solution would be to persist the data to a DB with a DAO and a web front end for CRUD operations. Frankly, until proven otherwise, I think a hard ...

If it's not to be at Geckon's end then the correct solution would be to persist the data to a DB with a DAO and a web front end for CRUD operations. Frankly, until proven otherwise, I think a hard coded solution is better. If it gets to be a problem we could move it into a custom config file in a future release.

ok.

ok.

ok.

ok.

Ok. Changed to nextElement.

Ok. Changed to nextElement.

Ok, I've added this as a TODO.

Ok, I've added this as a TODO.