jwat-parent

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
POM cleanup and modified to accomodate sonatype release. jwat-parent removed. Removed some tabs.
    • -20
    • +0
    ./src/main/resources/jwat/.checkstyle
    • -216
    • +0
    ./src/main/resources/jwat/checkstyle.xml
  1. … 7 more files in changeset.
Renamed packages to org.jwat.*, Mikis fixed assembly pomming, broke alot of unit tests.
  1. … 163 more files in changeset.
The next changeset is going to be fun. All arc/warc unit tests are failing after I renamed the packages from dk.netarkivet.jwat -> org.jwat.

The next changeset is going to be fun. All arc/warc unit tests are failing after I renamed the packages from dk.netarkivet.jwat -> org.jwat.

Done, including a one line javadoc for the whole class.

Done, including a one line javadoc for the whole class.

Add explanation to @param record Add circumstances to @throws IOException

Add explanation to @param record
Add circumstances to @throws IOException

Some of the implemented streams return -1 when reaching EOS, should be 0. Which is incorrect so I have to fix some of the streams, skip, close. And also fix some of the common, arc, warc code which...

Some of the implemented streams return -1 when reaching EOS, should be 0. Which is incorrect so I have to fix some of the streams, skip, close. And also fix some of the common, arc, warc code which uses -1 as skip EOS.

What was the bug?

What was the bug?

changes from review of last changeset. More unit test coverage of common. Found a serious bug which...
changes from review of last changeset. More unit test coverage of common. Found a serious bug which...
changes from review of last changeset. More unit test coverage of common. Found a serious bug which will be fixed in next changeset.
  1. … 31 more files in changeset.
DigestInputStream does not override the skip method. So skipping on a DigestInputStream will calculate an incorrect message digest. You never know what those evil package users will do.

DigestInputStream does not override the skip method. So skipping on a DigestInputStream will calculate an incorrect message digest. You never know what those evil package users will do.

I just need to shield the close method of the inputstream so package users can't close stream but have to use the close() method on the payload.

I just need to shield the close method of the inputstream so package users can't close stream but have to use the close() method on the payload.

Its not. Thats the callers problem.

Its not. Thats the callers problem.

Ill rewrite in utf-8 and try to add an xml header with encoding too.

Ill rewrite in utf-8 and try to add an xml header with encoding too.

Good point, Ill change all methods in bases to return in instead of null when null or "". Well two if instead.

Good point, Ill change all methods in bases to return in instead of null when null or "". Well two if instead.

Since digest support in ARC reader is an unscheduled issue I will add a waste of heap space this time.

Since digest support in ARC reader is an unscheduled issue I will add a waste of heap space this time.

My name doesn't look very nice in crucible!

My name doesn't look very nice in crucible!

missing javadoc or @Override

missing javadoc or @Override

wrong indentation

wrong indentation

missing javadoc or @override

missing javadoc or @override

or null => or null if we don't make a digest of the payload

or null => or null if we don't make a digest of the payload

errors occurs => errors occur

errors occurs => errors occur

missing javadoc

missing javadoc

spelling: concatenate string => concatenated string

spelling: concatenate string => concatenated string

wrong param: valueList instead of valueStr

wrong param: valueList instead of valueStr

the indentation is wrong in some places

the indentation is wrong in some places

delete unused code. The same information is available in toString

delete unused code. The same information is available in toString